Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.google-auth: Fix tests after removing pyopenssl #180301

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Jul 6, 2022

Description of changes

See https://hydra.nixos.org/build/182833696/nixlog/1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jul 6, 2022

As the build regression only appear on the staging-next branch so far, I'll assume that the fix should also be targeted there.

@ofborg build python3Packages.google-auth

@ofborg ofborg bot requested a review from SuperSandro2000 July 6, 2022 14:04
@SuperSandro2000
Copy link
Member

Please prefix packages correct.

@ofborg build python310Packages.google-auth

@SuperSandro2000 SuperSandro2000 changed the title google-auth: Fix tests after removing pyopenssl python310Packages.google-auth: Fix tests after removing pyopenssl Jul 6, 2022
@SuperSandro2000 SuperSandro2000 merged commit be9b19d into NixOS:staging-next Jul 6, 2022
@azuwis azuwis deleted the google-auth branch July 9, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants