boost: if isMips use the "cross compile" codepath unconditionally #181160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
changed the title
boost-context changed its name for mips from "mips1" to "mips" in this commit: boostorg/context@6edc818 however the native-build code to detect the local architecture still reports "mips1": https://github.com/boostorg/boost/blob/67c074b249538cf441724f9bbb3929d0f6b4f333/boostcpp.jam#L637 Therefore native builds of boost-context on mips must specify architecture= explicitly; without this you will get link failures "undefined reference to `jump_fcontext`" in code that uses boost-context. Currently the "cross compile" codepath, which provides explicit architecture/abi/address-model/binary-format/os parameters, is prefixed by this comment: ``` # TODO: make this unconditional ``` This commit does so, at least if `isMips`. This commit is needed in order for native builds of nix to succeed on mips.
Mindavi
added
the
6.topic: cross-compilation
ghost
mentioned this pull request
3 tasks
|
Ping... |
|
@hjones2199 you are listed as the maintainer for boost; do you approve of this? |
The explanation for the conditional introduced by 61d9f20 is longer than a reasonable inline comment should be. It directed the reader to use `git blame`, but that tends to bitrot. Let's point the user to a specific nixpkgs git hash. This commit cannot be squashed into the previous commit, because a commit cannot mention its own commit-hash (without performaing an expensive double-sha1 preimage attack, of course).
ghost
mentioned this pull request
|
So uh, can you also ask upstream to do something about that? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is needed in order for native builds of nix to succeed on mips.
Description of changes
boost-context changed its name for mips from "mips1" to "mips" in this commit:
boostorg/context@6edc818
however the native-build code to detect the local architecture still reports "mips1":
https://github.com/boostorg/boost/blob/67c074b249538cf441724f9bbb3929d0f6b4f333/boostcpp.jam#L637
Therefore native builds of boost-context on mips must specify architecture= explicitly; without this you will get link failures "undefined reference to
jump_fcontext" in code that uses boost-context.Currently the "cross compile" codepath, which provides explicit architecture/abi/address-model/binary-format/os parameters, is prefixed by this comment:
This commit does so, at least if
isMips.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)