Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qemu-vm: Speed up tests with squashfs instead of stored ext4 image #181537

Closed
wants to merge 2 commits into from
Closed

nixos/qemu-vm: Speed up tests with squashfs instead of stored ext4 image #181537

wants to merge 2 commits into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Jul 14, 2022 •
edited
Loading

Description of changes

A possible alternative to #140792 that doesn't pollute stores and binary caches.

See analysis in #140792 (comment)

TODO

  • try squashfs without overlay for writeableStore = false
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

roberth added 2 commits July 15, 2022 00:15
@roberth
nixos/qemu-vm: Add virtualisation.squashPaths alternative to useNixSt…
de4833e 
…oreImage
@roberth
nixos/tests/gitlab: Use squashPaths instead of useNixStoreImage
b5895fc 
This degrades performance compared to the prebuilt ext4 image,
but does not require image rebuilds that are also expensive in both
time and space.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 14, 2022
@roberth roberth mentioned this pull request Jul 14, 2022
Merged
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 14, 2022
@roberth roberth added the 6.topic: testing Tooling for automated testing of packages and modules label Jul 15, 2022
@Tungsten842
Copy link
Member

I was looking at EROFS, and it's just like squashfs but faster, it seems like a good option for this PR.

@roberth
Copy link
Member Author

roberth commented Jul 16, 2022

I was looking at EROFS, and it's just like squashfs but faster, it seems like a good option for this PR.

I'll have to correct you on that. It is a great option :D

I ignored this one at first because its image creation tool does not support an include list, but I've come up with a workaround for that using regexes. (and I do realize I have two problems now)

New PR: #181746

@roberth roberth closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberth @Tungsten842