Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnamon 5.4 #181918

Merged
merged 32 commits into from
Aug 7, 2022
Merged

Cinnamon 5.4 #181918

merged 32 commits into from
Aug 7, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jul 18, 2022

Description of changes

Linux Mint 21 has been released on 31, July, 2022.

https://blog.linuxmint.com/?p=4358
https://www.linuxmint.com/rel_vanessa_cinnamon_whatsnew.php

Previous update: #147080

List of duplicate PRs that can be closed after merging

Closes #183980
Closes #183975
Closes #183985
Closes #183984
Closes #184378
Closes #184398
Closes #184448
Closes #184754
Closes #184772

@github-actions github-actions bot added 6.topic: cinnamon Desktop environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 18, 2022
@bobby285271 bobby285271 requested a review from mkg20001 July 18, 2022 07:50
@ofborg ofborg bot requested a review from linsui July 18, 2022 07:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jul 18, 2022
Copy link
Contributor

@linsui linsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticky builds fine and works well for me. Thanks!

@ofborg ofborg bot requested a review from linsui July 18, 2022 08:29
@bobby285271 bobby285271 force-pushed the cinnamon branch 3 times, most recently from 0c86486 to 7a963fd Compare July 23, 2022 15:51
@ofborg ofborg bot requested review from romildo and dotlambda July 26, 2022 13:43
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 27, 2022
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Jul 27, 2022
@bobby285271 bobby285271 force-pushed the cinnamon branch 3 times, most recently from d261f38 to 6e9ab9f Compare July 30, 2022 09:42
@bobby285271 bobby285271 marked this pull request as ready for review July 30, 2022 10:42
Removed pulseaudio as dependency because the sound plugin was removed.
Removed dbus{,-glib} as dependency as they now use Gio's dbus implementation.
dbus-glib is not needed since 4.6.2.
upower-glib is added when adapting to muffin changes.
Rebased on gjs 1.70.0.
Rebased on mutter 3.36.0-0ubuntu0.20.04.1.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1064

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@SuperSandro2000
Copy link
Member

gimme a nudge when we can merge this

@bobby285271
Copy link
Member Author

🤔 I don't have new things to address so far. This should be okay to go if there is no respond from pending reviewers but I think I will wait for a few more days.

@bobby285271 bobby285271 merged commit 9c16fe5 into master Aug 7, 2022
@bobby285271
Copy link
Member Author

I assume this is okay to go. Feedback is still welcomed if this PR introduces some regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cinnamon Desktop environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants