Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging-next 2022-07-21 #182386

Merged
merged 822 commits into from
Jul 27, 2022
Merged

staging-next 2022-07-21 #182386

merged 822 commits into from
Jul 27, 2022

Conversation

@jtojnar
Copy link
Member

jtojnar commented Jul 25, 2022

The e-d-s failure looks like something caused by the recent g-i fiddling, cc @Artturin

inherit version;
sha256 = "sha256-ConK3ABipeU2ZN3gQ/bAlxcrjBxfAJRJAJUoL/mZWl8=";
};
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't override packages inside python-modules, because it is easily results in conflicts when multiple packages depend on different versions while only one can claim the name inside the python environment.

If you want to fix matrix-synapse OTOH, an override there would be acceptable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used in tests (and in checkInputs), so I think it's fine here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well, if it's not propagated that should be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, and it doesn't look like anything in nixpkgs uses both pysaml2 and pymongo at the same time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't look like anything in nixpkgs uses both pysaml2 and pymongo at the same time.

but something could use it in the future. Don't we have a hook now that detects it? But I don't think it is perfect.

As long as this never gets propagated it should be fine ™️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something can even get away with using both, as long as it doesn't specifically use pymongo and the mongo storage for pysaml2, but if you're doing that, you'll explode anyway.

@Artturin
Copy link
Member

Artturin commented Jul 25, 2022

  • evolution-data-server; maintainers: @NixOS/gnome (hmm, seems not synced with our lib.teams.gnome, but perhaps Jan will be OK anyway)
    hydra.nixos.org/build/185044078 (later build hasn't finished yet on Hydra but still fails locally)

on it... look's like libical isn't building its gir and vapi files

on master

$ tree ./result1-dev/share
./result1-dev/share
├── gir-1.0
│   ├── ICal-3.0.gir
│   └── ICalGLib-3.0.gir
└── vala
    └── vapi
        └── libical-glib.vapi

EDIT its because libical needs to be explicitly told to build them

Artturin and others added 5 commits July 25, 2022 22:50
Let's stop using src.override.  I see no advantage,
and the switch of original src from `sha256 =` to `hash =`
was causing really confusing errors.
@vcunat vcunat mentioned this pull request Jul 26, 2022
13 tasks
@vcunat vcunat merged commit 29316ab into master Jul 27, 2022
@vcunat
Copy link
Member Author

vcunat commented Jul 27, 2022

The impact of the python package updates is not small, but I don't think that delaying merge would help significantly. (discussed with others on https://matrix.to/#/#staging:nixos.org )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.