Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wapm-cli: init at 0.5.5 #183477

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Jul 28, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@lucperkins
Copy link
Contributor Author

lucperkins commented Jul 28, 2022

@SuperSandro2000 @ghishadow My apologies for abandoning #94675! That was right during peak pandemic burnout time and I simply lost track. I was doing some GitHub housekeeping today and stumbled on that. This PR here should fix the issues introduced in that PR. Unfortunately, I seem to have deleted the original branch from my fork so I wasn't able to push to that original PR and had to open this one.

@SuperSandro2000
Copy link
Member

No problem at all :)

pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/package-management/wapm/cli/default.nix Outdated Show resolved Hide resolved
@ghishadow
Copy link

@ghishadow My apologies for abandoning #94675! That was right during peak pandemic burnout time and I simply lost track.
No worries, hope you had enough rest.

I was doing some GitHub housekeeping today and stumbled on that. This PR here should fix the issues introduced in that PR. Unfortunately, I seem to have deleted the original branch from my fork so I wasn't able to push to that original PR and had to open this one.

Thanks for working on it. Please Take care 😉

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jul 29, 2022
@cole-h
Copy link
Member

cole-h commented Jul 29, 2022

@ofborg eval

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jul 29, 2022
@SuperSandro2000 SuperSandro2000 merged commit 717f05b into NixOS:master Jul 30, 2022
@lucperkins lucperkins deleted the lperkins/add-wapm-cli branch August 2, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants