Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spice-gtk: 0.40 -> 0.41, add darwin support #183716

Merged
merged 1 commit into from
Jul 30, 2022
Merged

spice-gtk: 0.40 -> 0.41, add darwin support #183716

merged 1 commit into from
Jul 30, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Jul 29, 2022 •
edited by jtojnar
Loading

Description of changes

https://gitlab.freedesktop.org/spice/spice-gtk/-/blob/v0.41/CHANGELOG.md

Supersedes #183689 and #183674.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 29, 2022
This was referenced Jul 29, 2022
Closed
Closed
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 29, 2022
@ofborg ofborg bot requested review from offlinehacker and xeji July 29, 2022 16:06
@wegank wegank removed 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 10.rebuild-darwin: 1-10 labels Jul 29, 2022
@wegank
Copy link
Member Author

wegank commented Jul 29, 2022

@ofborg eval

@wegank wegank marked this pull request as ready for review July 29, 2022 16:24
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 29, 2022
@SuperSandro2000 SuperSandro2000 merged commit bf7e993 into NixOS:master Jul 30, 2022
@wegank wegank deleted the spice-gtk-darwin branch July 30, 2022 20:50
@Aleksanaa Aleksanaa mentioned this pull request Apr 1, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@xeji xeji Awaiting requested review from xeji

@jtojnar jtojnar Awaiting requested review from jtojnar

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wegank @jtojnar @SuperSandro2000