Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt_9: init at 9.0.0 #187482

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fmt_9: init at 9.0.0 #187482

merged 1 commit into from
Sep 2, 2022

Conversation

panicgh
Copy link
Contributor

@panicgh panicgh commented Aug 19, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@IvarWithoutBones
Copy link
Member

Hmm, creating seperate attribute paths for all new releases doesn't seem the greatest. It was originally done for version 8 as many packages broke with the update, but (AFAIK?) that shouldn't be the case with this update.

The packages still using version 7 should get updated to the latest, so that we can remove it.

For now I suppose this is fine, maybe we should also introduce a temporary fmt_latest attribute which we can switch other packages to?

@panicgh panicgh changed the title fmt_9: init at 9.0.0 fmt_latest: init at 9.0.0 Aug 25, 2022
@panicgh
Copy link
Contributor Author

panicgh commented Aug 25, 2022

Thanks for the comment. I updated the commit as per your suggestion to fmt_latest.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • fmt_latest

I tried also fmt_8 -> fmt_latest and did a nixpkgs-review, but many packages would become broken (it may look similar for fmt_7). So I think it must be done gradually and per package:

3 packages marked as broken and skipped:
libsForQt512.plasma-vault libsForQt514.plasma-vault lizardfs

51 packages failed to build:
contour cryfs gerbera gnss-sdr gnuradio gnuradioMinimal gnuradio3_9Packages.gnuradio hal-hardware-analyzer irods irods-icommands kodi kodi-gbm kodi-wayland kodiPackages.a4ksubtitles kodiPackages.archive_tool kodiPackages.iagl kodiPackages.inputstream-adaptive kodiPackages.inputstream-ffmpegdirect kodiPackages.inputstream-rtmp kodiPackages.invidious kodiPackages.joystick kodiPackages.kodi-platform kodiPackages.libretro kodiPackages.libretro-genplus kodiPackages.libretro-mgba kodiPackages.libretro-snes9x kodiPackages.netflix kodiPackages.pvr-hdhomerun kodiPackages.pvr-hts kodiPackages.pvr-iptvsimple kodiPackages.steam-controller kodiPackages.vfs-libarchive kodiPackages.vfs-sftp libsForQt5.plasma-vault openroad python310Packages.qiskit python310Packages.qiskit-aer python310Packages.qiskit-finance python310Packages.qiskit-ibmq-provider python310Packages.qiskit-ignis python310Packages.qiskit-nature python310Packages.qiskit-optimization python39Packages.qiskit python39Packages.qiskit-aer python39Packages.qiskit-finance python39Packages.qiskit-ibmq-provider python39Packages.qiskit-ignis python39Packages.qiskit-nature python39Packages.qiskit-optimization vowpal-wabbit waybar

27 packages built:
ananicy-cpp bear cherrytree coeurl dwarfs easyeffects far2l fmt_latest folly furnace mariadb_107 mariadb_108 micromamba mtxclient nheko nrfutil pc-ble-driver pynitrokey python310Packages.pc-ble-driver-py python310Packages.vowpalwabbit python39Packages.pc-ble-driver-py python39Packages.vowpalwabbit spdlog wasmedge wdt yuzu-early-access yuzu-mainline

Should fmt_latest and the possible bumps fmt_x -> fmt_latest in various packages be backported to 22.05?

@bachp
Copy link
Member

bachp commented Aug 30, 2022

What about adding fmt_9 and then at some point do fmt = fmt_9?

@panicgh panicgh changed the title fmt_latest: init at 9.0.0 fmt_9: init at 9.0.0 Aug 31, 2022
@panicgh
Copy link
Contributor Author

panicgh commented Aug 31, 2022

Ok, now I'm trying to satisfy both sides: I reintroduced fmt_9 and made an fmt_latest = fmt_9 alias.

New packages can start using fmt_latest. Then later, someone makes a new PR for

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 31, 2022
@bachp bachp merged commit 5660337 into NixOS:master Sep 2, 2022
@panicgh panicgh deleted the bump-fmt branch September 3, 2022 14:55
@panicgh panicgh mentioned this pull request Jan 3, 2023
13 tasks
panicgh added a commit to panicgh/nixpkgs that referenced this pull request Jan 22, 2023
Change the default fmt alias from fmt_7 to fmt_9 (i.e. the latest).

Follow-up on PR NixOS#187482 (5660337).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants