Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-crate-overrides.nix: add gtk-sys (gtk3) #190610

Merged
merged 1 commit into from Apr 22, 2023
Merged

default-crate-overrides.nix: add gtk-sys (gtk3) #190610

merged 1 commit into from Apr 22, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 10, 2022
@ghost ghost marked this pull request as draft September 12, 2022 04:30
@ghost ghost marked this pull request as ready for review September 12, 2022 05:06
@ghost
Copy link
Author

ghost commented Jan 2, 2023

Resolved merge conflict.

@alyssais
Copy link
Member

Seems like now gobject-sys is failing before it even gets to the crates here.

(Also, would you mind sticking to at most one commit per crate? The commits are a bit noisy to read through when they go back and redo earlier commits. Thanks!)

@ghost
Copy link
Author

ghost commented Jan 13, 2023

(Also, would you mind sticking to at most one commit per crate? The commits are a bit noisy to read through when they go back and redo earlier commits. Thanks!)

Sorry about that. These came about piecemeal when I managed to get gtk4-rs working in crate2nix for nix-garta. I should have just kept pushing more commits onto a single PR.

Seems like now gobject-sys is failing before it even gets to the crates here.

Investigating.

@ghost ghost marked this pull request as draft January 13, 2023 19:01
@alyssais
Copy link
Member

I should have just kept pushing more commits onto a single PR.

Many PRs is fine — it's just the commit structure I was talking about.

@ghost
Copy link
Author

ghost commented Jan 15, 2023

(Also, would you mind sticking to at most one commit per crate? The commits are a bit noisy to read through when they go back and redo earlier commits. Thanks!)

I think this is fallout from an earlier rebase I did wrong. Sorry about that.

Many PRs is fine — it's just the commit structure I was talking about.

I would like to split out default-crate-overrides.nix into separate files, so the default-crate-overrides.nix becomes just (roughly) mapAttrs callPackage (builtins.readDir ./). Sort of like we keep talking about doing to all-packages.nix.

@ghost ghost marked this pull request as ready for review January 15, 2023 23:49
@Artturin Artturin merged commit 5fd9ce4 into NixOS:master Apr 22, 2023
@ghost ghost deleted the pr/build-rust-crate/gdk3 branch April 24, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants