Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt-6/modules/qtbase: add systemdSupport parameter #192057

Merged
merged 2 commits into from Jan 11, 2023
Merged

qt-6/modules/qtbase: add systemdSupport parameter #192057

merged 2 commits into from Jan 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 20, 2022

Description of changes

Defaults to stdenv.isLinux. Tested by building ladybird with .override { systemdSupport = false; }.

Things done
  • Built on platform(s)
    • x86_64-linux
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/: ladybird)
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member

NickCao commented Sep 20, 2022

Should systemd also be removed from buildInputs when systemdSupport is disabled?

@ghost
Copy link
Author

ghost commented Sep 21, 2022

Should systemd also be removed from buildInputs when systemdSupport is disabled?

Yes thank you; I didn't notice that because I have to .override { systemd=null; } Edit:

(final: prev: { systemdMinimal = prev.eudev; systemd = prev.eudev; udev = prev.eudev; })

due to there being a few packages (like emacs) that still don't respect systemdSupport.

@ghost ghost requested a review from NickCao September 21, 2022 00:50
@NickCao
Copy link
Member

NickCao commented Sep 21, 2022

Notice that udev is also systemd under the hood, better check if that matters.

@ghost
Copy link
Author

ghost commented Sep 21, 2022

Notice that udev is also systemd under the hood, better check if that matters.

Ah yes, I keep forgetting about that. Such a footgun. Why can't we just call udev udev anymore...

@ghost ghost marked this pull request as draft September 21, 2022 02:00
@ghost
Copy link
Author

ghost commented Sep 21, 2022

Notice that udev is also systemd under the hood, better check if that matters.

Fortunately it does not matter in this case.

@ghost ghost marked this pull request as ready for review September 21, 2022 22:29
@ghost
Copy link
Author

ghost commented Nov 5, 2022

Ping

@ghost
Copy link
Author

ghost commented Jan 2, 2023

Resolved merge conflict.

@Artturin
Copy link
Member

Notice that udev is also systemd under the hood, better check if that matters.

Ah yes, I keep forgetting about that. Such a footgun. Why can't we just call udev udev anymore...

because udev was merged in to systemd in 2012

@Artturin Artturin merged commit 250e410 into NixOS:master Jan 11, 2023
@ghost
Copy link
Author

ghost commented Jan 12, 2023

because udev was merged in to systemd in 2012

There are at least two non-systemd packages that provide udev implementations. One of them had udev as "merged into" it too!

We really ought to have a top-level udev which defaults to systemd. Or if it's a branding thing call it xdev instead.

We refer to:

  • both gcc and clang as stdenv.cc
  • both glibc and musl as libc
  • both openjdk and semeru 😕 and temurin 😵 as jdk
  • both binutils and somedarwinthing as bintools
  • both npth and gnupth as pth
  • both bash and busybox as stdenv.shell

@NickCao
Copy link
Member

NickCao commented Jan 12, 2023

Calling it udev is fine. Selecting different implementations conditionally is being implemented: #210276

@ghost
Copy link
Author

ghost commented Jan 12, 2023

Selecting different implementations conditionally is being implemented: #210276

Hooray!

@ghost ghost deleted the pr/qt6/systemdSupport branch January 12, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants