-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune old aliases #192681
Prune old aliases #192681
Conversation
This removes throws older than 2021-09-01, converts aliases older than 2021-09-01 to throws and fills in missing dates here and there.
This removes throws odler than 2021-09-01, converts aliases older than 2021-09-01 to throws and fills in missing dates in two cases.
d7c3930
to
ddb7c7b
Compare
Seems like `runCommandNoCC` is creating issues, might be temporary. See NixOS/nixpkgs#192681
The rename was done long ago in NixOS/nixpkgs#122107 (back in 21.05), and since NixOS/nixpkgs#192681 the old `gnome3` name no longer works. Update the old virt-manager package accordingly.
The rename was done long ago in NixOS/nixpkgs#122107 (back in 21.05), and since NixOS/nixpkgs#192681 the old `gnome3` name no longer works. Update the old virt-manager package accordingly.
Recently nixpkgs removed the `pkgconfig` alias [1], which broke the build with nix-shell. [1] NixOS/nixpkgs#192681
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/mpv-with-scripts-has-been-renamed/22017/3 |
It has been synonymous with runCommand since NixOS/nixpkgs@97bfc2f (2016-09-26), was deprecated in NixOS/nixpkgs#134225 (2021-08-15), and was removed in NixOS/nixpkgs#192681 (2022-09-24). Signed-off-by: Anders Kaseorg <andersk@mit.edu>
No longer exists in unstable since NixOS/nixpkgs#192681.
No longer exists in unstable since NixOS/nixpkgs#192681.
mutt-with-sidebar = mutt; # Added 2022-09-17 | ||
mysql-client = hiPrio mariadb.client; | ||
mysql = mariadb; # moved from top-level 2021-03-14 | ||
mysql-client = throw "'mysql-client' has been renamed to/replaced by 'hiPrio'"; # Converted to throw 2022-09-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change this message to ...replaced by 'mariadb.client'
? This thoroughly confused me for a moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug in maintainers/scripts/remove-old-aliases.py then. Feel free to submit a PR yourself, I'm currently otherwise occupied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included fixing the generated line in PR #193914
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Removed in commit 57b25916f32 from PR NixOS#192681.
Recently nixpkgs removed the `pkgconfig` alias[^1], which broke the build with `nix-shell`. [^1]: NixOS/nixpkgs#192681 Closes: #153 Closes: #158
It has been synonymous with runCommand since NixOS/nixpkgs@97bfc2f (2016-09-26), was deprecated in NixOS/nixpkgs#134225 (2021-08-15), and was removed in NixOS/nixpkgs#192681 (2022-09-24). Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This was broken after NixOS/nixpkgs#192681
`etc/shell.nix`: Replace `pkgconfig` with `pkg-config` `pkgconfig` is [an old name][1] of `pkg-config` that has been [completely removed][2] in a recent version of nixpkgs. [1]: NixOS/nixpkgs#55094 [2]: NixOS/nixpkgs#192681 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) --- - [ ] There are tests for these changes OR - [x] These changes do not require tests because they don't affect the production code
This removes throws older than 2021-09-01, converts aliases older than
2021-09-01 to throws and fills in missing dates here and there.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes