systemd: default withLibBPF to false if isMips64 #194149
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
ghost
mentioned this pull request
|
Is there anywhere upstream it would make sense to report this? |
That's a good question.
So now I'm thinking that this is actually a nixpkgs bug -- that we're not invoking clang in a way that tells the frontend to make the mips builtins available, even if the backend is emitting mips binaries. Or at least we aren't tricking systemd's build machinery into doing that. I'm draftifying this while I try to figure that out. Maybe we can leave |
ghost
marked this pull request as draft
ghost
mentioned this pull request
|
I've rebased this and included everything I know about the situation in the commit message. Realistically I am not likely to have time to fix this in the next few months. I know that's not ideal, but in the meantime I think that disabling |
ghost
marked this pull request as ready for review
This comment was marked as resolved.
This comment was marked as resolved.
libBPF does not compile for mips64 targets using clang (rathern than gcc) because clang lacks the necessary _MIPS_SZPTR compiler builtin. Let's allow the rest of systemd to compile. - The glibc people noticed this problem [way back in 2011](https://sourceware.org/pipermail/libc-ports/2011-June/001959.html) and consider it to be a clang/llvm bug. I am inclined to agree. - [clang has the `_MIPS_SZPTR` builtin](https://github.com/llvm/clangir/blob/3af9cb5375084541165b4b63d36e3798801c95ab/clang/lib/Basic/Targets/Mips.cpp#L185) and seems to have had it since before they switched to git. This may in fact be a nixpkgs bug -- that we're not invoking clang in a way that tells the frontend to make the mips builtins available, even if the backend is emitting mips binaries. Or at least we aren't tricking systemd's build machinery into doing that.
|
Pushed a formatting fix, per the comment at the top of the file. |
Description of changes
libBPF does not compile for mips64 targets using clang (rathern than gcc) because clang lacks the necessary _MIPS_SZPTR compiler builtin. Let's allow the rest of systemd to compile.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)