Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testers: Add testBuildFailure and testEqualContents #196251

Merged
merged 3 commits into from
Nov 21, 2022
Merged

testers: Add testBuildFailure and testEqualContents #196251

merged 3 commits into from
Nov 21, 2022

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 16, 2022

Description of changes

Adds testers to check that

  • a path has the same contents as another path
  • a tester or any function produces a build failure when it needs to

Tested with nix-build -A tests.testers.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@roberth roberth added the 6.topic: testing Tooling for automated testing of packages and modules label Oct 16, 2022
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Oct 16, 2022
@roberth
Copy link
Member Author

roberth commented Oct 16, 2022 •
edited
Loading

@ofborg build tests.testers.testBuildFailure tests.testers.testEqualContents

@roberth roberth force-pushed the testers-build-failure-and-equal-contents branch 2 times, most recently from 4565e5d to 16d091d Compare October 16, 2022 08:18
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 16, 2022
@roberth roberth force-pushed the testers-build-failure-and-equal-contents branch from 16d091d to 5dda41f Compare October 16, 2022 08:44
@roberth roberth changed the title testers: Add build failure and equal contents testers testers: Add testBuildFailure and testEqualContents Oct 16, 2022
@roberth roberth force-pushed the testers-build-failure-and-equal-contents branch from 5dda41f to 3cf3fef Compare October 27, 2022 12:07
@roberth roberth mentioned this pull request Nov 12, 2022
Merged
13 tasks
@roberth roberth merged commit 2935275 into NixOS:master Nov 21, 2022
@roberth roberth mentioned this pull request Nov 21, 2022
Closed
@roberth roberth mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

Assignees
No one assigned
Labels
6.topic: testing Tooling for automated testing of packages and modules 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roberth