rpm: remove darwin from supported platforms #196350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
|
Upstream issue here rpm-software-management/rpm#2222 |
|
I think it's fair to drop platform support until upstream released a fix. |
cbourjau
added a commit
to cbourjau/nixpkgs
that referenced
this pull request
Dec 12, 2022
RPM is no longer available for Darwin ( NixOS#196350 ). Libsolv is used by downstream packages such as micromamba which have no requirement on RPM.
13 tasks
|
upstream doesn't plan to support macos < 13. read the notes from the upstream issue link |
cbourjau
added a commit
to cbourjau/nixpkgs
that referenced
this pull request
Jan 15, 2023
RPM is no longer available for Darwin ( NixOS#196350 ). Libsolv is used by downstream packages such as micromamba which have no requirement on RPM. (cherry picked from commit a5160ce)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since 4.18.0, rpm does not compile on platforms without mkfifoat (so for example macos).
This can be rectified by either providing a patch that reverts the at* change for
!stdenv.isLinux, or by removing darwin from supported platforms.What do you think @copumpkin ?
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes