Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsMusl.firefox: fix build #198773

Merged
merged 3 commits into from
Apr 26, 2023
Merged

pkgsMusl.firefox: fix build #198773

merged 3 commits into from
Apr 26, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Oct 31, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka changed the base branch from staging-next to staging October 31, 2022 10:23
@ofborg ofborg bot requested a review from jopejoe1 April 7, 2023 20:58
@yu-re-ka yu-re-ka marked this pull request as ready for review April 8, 2023 14:42
@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Apr 9, 2023

@mweinelt can you have a look at this? It is finally in a state where it could be merged.

@yu-re-ka yu-re-ka changed the base branch from staging to master April 25, 2023 20:20
@ofborg ofborg bot requested a review from mweinelt April 25, 2023 21:03
@ofborg ofborg bot requested a review from vcunat April 26, 2023 10:50
@yu-re-ka
Copy link
Contributor Author

Testing the build with 9db75af once more

vcunat
vcunat approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, assuming it fixes musl issues.

@ofborg ofborg bot requested review from mweinelt and vcunat April 26, 2023 13:47
@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

I confirm that the default firefox-unwrapped still builds on x86_64-linux (unsurprisingly).

@yu-re-ka yu-re-ka merged commit 7a32a14 into NixOS:master Apr 26, 2023
@yu-re-ka yu-re-ka deleted the musl-firefox2 branch April 26, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrry retrry Awaiting requested review from retrry

@squalus squalus Awaiting requested review from squalus

@nbp nbp Awaiting requested review from nbp

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

@edolstra edolstra Awaiting requested review from edolstra

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1

@mweinelt mweinelt Awaiting requested review from mweinelt

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yu-re-ka @vcunat @mweinelt