Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsncd: unstable-2021-10-20 -> unstable-2022-11-14 #201468

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

picnoir
Copy link
Member

@picnoir picnoir commented Nov 16, 2022

This bump fixes the response format for IPV6-only requests. The bogus response message was crashing glibc.

See nix-community/nsncd#1 for more informations.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@picnoir
Copy link
Member Author

picnoir commented Nov 16, 2022

Hmm, there's something fishy, don't merge that yet.

This bump fixes the response format for IPV6-only requests. The bogus
response message was crashing glibc.

See nix-community/nsncd#1 for more informations.
@flokli
Copy link
Contributor

flokli commented Nov 16, 2022

Yeah, cargoSha256 wasn't up to date. Now with the right hash, this builds (and nixosTests.nscd still succeeds).

Do you want to add a v6 regression test to the VM test?

@picnoir
Copy link
Member Author

picnoir commented Nov 16, 2022

I think it should rather live in the nsncd test suite itself. We should add some wire format tests.

We had some before the rebase: picnoir/nsncd@2a88241#diff-148e623ad4cdaab49b81901460099f4efe7900e8c57e4f7a0ff6778589be01f8R412. We should probably bring them back and extend them.

Let's discuss that on the nsncd repo though, it's not nixpkgs-related :)

@flokli flokli merged commit 14cf8aa into NixOS:master Nov 16, 2022
@picnoir picnoir deleted the nin/bump-nsncd branch November 16, 2022 09:54
@ofborg ofborg bot requested a review from flokli November 16, 2022 09:55
@picnoir
Copy link
Member Author

picnoir commented Nov 16, 2022

Wire test discussion cont': nix-community/nsncd#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants