fix splicing in overrideAttrs #201734

Artturin · 2022-11-18T06:07:23Z

see commit messages

Things done

lib/customisation.nix

roberth

The root cause of the problem is doing // on an attrset that is supposed to be modified with .overrideAttrs instead.
This happens here:

nixpkgs/pkgs/top-level/splice.nix

Lines 50 to 52 in cf01bae

    
           // (lib.optionalAttrs (pkgsBuildHost ? ${name}) { nativeDrv = valueBuildHost; }) 
        
           // (lib.optionalAttrs (pkgsHostTarget ? ${name}) { crossDrv = valueHostTarget; }) 
        
           // {

What this code should do instead, is overrideAttrs with passthru.__spliced. That way the splicing is preserved, but broken, because overrideAttrs doesn't implement your logic yet. For this, we need to make overrideAttrs overridable. You may cherry-pick hercules-ci@43c8b43 for that. Here's a crude example showing that splicing can be made to work:

{ pkgs ? import ./. { }, ... }:
rec {
  inherit pkgs;
  inherit (pkgs) lib;

  addEntangled = origOverrideAttrs: f:
    origOverrideAttrs (
      lib.composeExtensions f (self: super: {
        passthru = super.passthru // {
          entangled = super.passthru.entangled.overrideAttrs f;
          overrideAttrs = addEntangled self.overrideAttrs;
        };
      })
    );

  entangle = pkg1: pkg2: pkg1.overrideAttrs (self: super: {
    passthru = super.passthru // {
      entangled = pkg2;
      overrideAttrs = addEntangled self.overrideAttrs;
    };
  });

  example = entangle pkgs.hello pkgs.figlet;

  overrides1 = example.overrideAttrs (self: super: { pname = "a-better-${super.pname}"; });

  repeatedOverrides = overrides1.overrideAttrs (self: super: { pname = "${super.pname}-with-blackjack"; });

  test =
    assert repeatedOverrides.pname == "a-better-hello-with-blackjack";
    assert repeatedOverrides.entangled.pname == "a-better-figlet-with-blackjack";
    "ok";
}

doc/stdenv/cross-compilation.chapter.md

roberth · 2022-11-18T18:29:20Z

Here's a crude example

I'll add that it's very crude. I've untangled the entangle function a bit by floating out addEntangled. See edited example above.
I think the pattern could be extracted into a higher order function, but I don't know if that will make things better or worse. Maybe it's best to adapt it to __spliced and avoid the indirection.

Artturin · 2022-11-19T03:29:15Z

Thank you @roberth!!

This test passes

let
  pkgs = ((builtins.getFlake (toString ./.)).legacyPackages.${builtins.currentSystem});
  pkgsCross = pkgs.pkgsCross.aarch64-multiplatform.__splicedPackages;
  lib = pkgs.lib;
  test = let
    pythonInNativeBuildInputs = lib.elemAt pkgsCross.python3Packages.xpybutil.nativeBuildInputs 0;
    overridenAttr = pkgsCross.hello.overrideAttrs (_: { something = "hello"; });
    #overridenAttr = (pkgsCross.hello.overrideAttrs (previousAttrs: { something = "hello"; })) // { __spliced = { buildHost = { something = "hello"; }; };};
  in {
    shouldBeNative = pythonInNativeBuildInputs.stdenv.hostPlatform.system == "x86_64-linux";
    notCrossOverriden = pkgs.hello.overrideAttrs (_: _: { passthru = { o = "works"; }; });
    inherit overridenAttr;
    overridenAttrShouldHaveSpliced = overridenAttr ? __spliced;
    overridenAttrShouldHaveSplicedAndSomething = if overridenAttr ? __spliced then overridenAttr.something == overridenAttr.__spliced.buildHost.something else false;

  };
in
  assert test.shouldBeNative == true;
  assert test.overridenAttrShouldHaveSpliced == true;
  assert test.overridenAttrShouldHaveSplicedAndSomething == true;
  assert test.notCrossOverriden.o == "works";
  test

Artturin · 2022-11-19T03:57:43Z

output getting broken now
before

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.dev
"/nix/store/rdn3ky83pa8xz9prqip7mkw7618jjcv3-zlib-aarch64-unknown-linux-gnu-1.2.13-dev"

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.out
"/nix/store/br4j85mlmiw2qsh2aan1wv7dyz061d80-zlib-aarch64-unknown-linux-gnu-1.2.13"

after

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.dev
"/nix/store/zdx7909kskhm21l89jg62w0qmmgnqjc4-zlib-aarch64-unknown-linux-gnu-1.2.13"

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.out
"/nix/store/zdx7909kskhm21l89jg62w0qmmgnqjc4-zlib-aarch64-unknown-linux-gnu-1.2.13"

hmm

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.__spliced.hostTarget.dev
"/nix/store/9c7539rzxnjy0630c09pda4nmsp55x80-zlib-aarch64-unknown-linux-gnu-1.2.13-dev"

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.dev
"/nix/store/zdx7909kskhm21l89jg62w0qmmgnqjc4-zlib-aarch64-unknown-linux-gnu-1.2.13"

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib
"/nix/store/zdx7909kskhm21l89jg62w0qmmgnqjc4-zlib-aarch64-unknown-linux-gnu-1.2.13"

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.__spliced.hostTarget
"/nix/store/zdx7909kskhm21l89jg62w0qmmgnqjc4-zlib-aarch64-unknown-linux-gnu-1.2.13"

roberth · 2022-11-19T10:43:26Z

Pushed a fix.

nix-repl> toString pkgsCross.aarch64-multiplatform.__splicedPackages.zlib.dev  
"/nix/store/rdn3ky83pa8xz9prqip7mkw7618jjcv3-zlib-aarch64-unknown-linux-gnu-1.2.13-dev

The TODOs in it are out of scope for this PR.

Artturin · 2022-11-19T10:44:35Z

Awesome, thanks.

roberth · 2022-12-16T19:01:02Z

pkgs/development/interpreters/python/python-packages-base.nix

@@ -19,9 +19,9 @@ let
      ff = f origArgs;
      overrideWith = newArgs: origArgs // (if pkgs.lib.isFunction newArgs then newArgs origArgs else newArgs);
    in
-      if builtins.isAttrs ff then (ff // {
+      if builtins.isAttrs ff then ff.overrideAttrs (previousAttrs: { passthru = (previousAttrs.passthru or {}) // {


For performance, it'd be better to composeExtensions (or similar) this to the origArgs. That way we don't evaluate all python packages twice.

Artturin · 2022-12-16T19:04:53Z

Some overrides still missing
pkgsCross.aarch64-multiplatform.nix:
nix-repl> pkgsCross.aarch64-multiplatform.__splicedPackages.nix.boehmgc.configureFlags
[ "--enable-cplusplus" "--with-libatomic-ops=none" "--enable-mmap" "--enable-large-config" "--build=x86_64-unknown-linux-gnu" "--host=aarch64-unknown-linux-gnu" ]
which attr are you talking about? they seem to be there

# merge base
$ git checkout dba0c71b6d15e323d4b8235d9474322520938dc8
$ nix repl .
nix-repl> pkgsCross.aarch64-multiplatform.nix
«derivation /nix/store/dwp0b9ncbwp9h1ypxl42pml3y7vilpx4-nix-aarch64-unknown-linux-gnu-2.11.0.drv»

# this pr
$ git checkout bc5e0b3dae45d858980cead0cb657a38d1be5e22
$ nix repl .
nix-repl> pkgsCross.aarch64-multiplatform.nix                        
«derivation /nix/store/g8hvw7ckadfs1x7ls62zqb7kp2wh36yl-nix-aarch64-unknown-linux-gnu-2.11.0.drv»

$ nix-diff /nix/store/dwp0b9ncbwp9h1ypxl42pml3y7vilpx4-nix-aarch64-unknown-linux-gnu-2.11.0.drv /nix/store/g8hvw7ckadfs1x7ls62zqb7kp2wh36yl-nix-aarch64-unknown-linux-gnu-2.11.0.drv
# nix-diff needs color to be readable.
# `--enable-large-config` and some aws flags went missing as described

So this does appear to be a regression. I don't understand why it doesn't show in attributes.

figured out that this is caused by these

nixpkgs/pkgs/stdenv/generic/make-derivation.nix

Lines 209 to 240 in dbc68fa

    
           dependencies = map (map lib.chooseDevOutputs) [ 
        
             [ 
        
               (map (drv: drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild)) 
        
               (map (drv: drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs 
        
                  ++ lib.optional separateDebugInfo' ../../build-support/setup-hooks/separate-debug-info.sh 
        
                  ++ lib.optional stdenv.hostPlatform.isWindows ../../build-support/setup-hooks/win-dll-link.sh 
        
                  ++ lib.optionals doCheck checkInputs 
        
                  ++ lib.optionals doInstallCheck' installCheckInputs)) 
        
               (map (drv: drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget)) 
        
             ] 
        
             [ 
        
               (map (drv: drv.__spliced.hostHost or drv) (checkDependencyList "depsHostHost" depsHostHost)) 
        
               (map (drv: drv.__spliced.hostTarget or drv) (checkDependencyList "buildInputs" buildInputs)) 
        
             ] 
        
             [ 
        
               (map (drv: drv.__spliced.targetTarget or drv) (checkDependencyList "depsTargetTarget" depsTargetTarget)) 
        
             ] 
        
           ]; 
        
           propagatedDependencies = map (map lib.chooseDevOutputs) [ 
        
             [ 
        
               (map (drv: drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuildPropagated" depsBuildBuildPropagated)) 
        
               (map (drv: drv.__spliced.buildHost or drv) (checkDependencyList "propagatedNativeBuildInputs" propagatedNativeBuildInputs)) 
        
               (map (drv: drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTargetPropagated" depsBuildTargetPropagated)) 
        
             ] 
        
             [ 
        
               (map (drv: drv.__spliced.hostHost or drv) (checkDependencyList "depsHostHostPropagated" depsHostHostPropagated)) 
        
               (map (drv: drv.__spliced.hostTarget or drv) (checkDependencyList "propagatedBuildInputs" propagatedBuildInputs)) 
        
             ] 
        
             [ 
        
               (map (drv: drv.__spliced.targetTarget or drv) (checkDependencyList "depsTargetTargetPropagated" depsTargetTargetPropagated)) 
        
             ] 
        
           ];

before we just chose the overriden drv because there were no __spliced after .override
now we're choosing the non .overriden drv from __spliced

Artturin · 2022-12-17T22:25:59Z

pkgs/development/interpreters/python/python-packages-base.nix

+      args = lib.fix (lib.extends
+        (_: previousAttrs: {
+          passthru = (previousAttrs.passthru or { }) // {
+            overridePythonAttrs = newArgs: makeOverridablePythonPackage f (overrideWith newArgs);
+          };
+        })
+        (_: origArgs));


is this correct @roberth ?

I think the ordering of the extends arguments is ok. "Self" is ignored, so I think the types line up (but I didn't prove it).
Looks about right.

Performance has improved by 2-3%, judging by memory stats before and after "use extends instead of overrideAttrs".
Not enough to make python changes as cheap as the other changes though.
I wonder how much change/noise is caused by master, which I believe is merged into the feature branch before ofborg evaluates.

rebased on master again

We should probably bench this manually anyway, since cross is not part of ofborg's eval I think.

current stats

Artturin · 2023-01-15T04:15:05Z

lib/customisation.nix

+          # is this even necessary?
+          # nix-diff shows no difference in cross/non
+          # nix-diff $(nix eval --raw "nixpkgs/$(git merge-base upstream/master HEAD)#nix.drvPath") $(nix eval --raw ".#nix.drvPath")
+          # nix-diff $(nix eval --raw "nixpkgs/$(git merge-base upstream/master HEAD)#pkgsCross.aarch64-multiplatform.nix.drvPath") $(nix eval --raw ".#pkgsCross.aarch64-multiplatform.nix.drvPath")
+          #overrideAttrs = fdrv:
+          #  overrideResult (x: x.overrideAttrs fdrv);
+        #}


the overrideAttrs attr was added in commit 39b64b5

the commit message says

Also update makeOverridable so that uses of overrideAttrs can be
followed by override and overrideDerivation, i.e. they can be
mix-and-matched.

but it seems not necessary anymore

nix-repl> (bash.overrideAttrs(_: { x = "y"; })) «derivation /nix/store/vk0b51d4bq0ciyrr83nvgrbf51lp5f7s-bash-5.2-p15.drv» nix-repl> (bash.overrideAttrs(_: { x = "y"; })).override { withDocs = true; } «derivation /nix/store/y11vah7v46mah4yjj3yj7161fcaq7lkq-bash-5.2-p15.drv»

no overrideAttrs after .override so something like this is necessary

nix-repl> p = (pkgsCross.aarch64-multiplatform.__splicedPackages.bash.overrideAttrs(_: { x = "y"; })).over ride { withDocs = true; } nix-repl> p.passthru { override = { ... }; overrideDerivation = «lambda @ /home/hm7/nixgits/my-nixpkgs/lib/customisation.nix:96:34»; shellPath = "/bin/bash"; }

just uncommenting it gives

$ nix build ".#sway" --show-trace error: … while calling the 'derivationStrict' builtin at <nix/derivation-internal.nix>:9:12: 8| 9| strict = derivationStrict drvAttrs; | ^ 10| … while evaluating the attribute 'paths' of the derivation 'sway-1.8' … while evaluating the attribute 'text' of the derivation 'sway' … while evaluating the attribute 'buildInputs' of the derivation 'sway-unwrapped-1.8' … while evaluating the attribute 'buildInputs' of the derivation 'pango-1.50.12' … while evaluating the attribute 'buildCommand' of the derivation 'gobject-introspection-wrapped-1.74.0' … from call site at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/gobject-introspection/wrapper.nix:100:11: 99| eval fixupPhase 100| ${lib.concatMapStrings (output: '' | ^ 101| mkdir -p ${"$" + "${output}"} … while calling 'concatMapStrings' at /home/artturin/nixgits/my-nixpkgs/lib/strings.nix:55:25: 54| */ 55| concatMapStrings = f: list: concatStrings (map f list); | ^ 56| … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/gobject-introspection/wrapper.nix:100:33: 99| eval fixupPhase 100| ${lib.concatMapStrings (output: '' | ^ 101| mkdir -p ${"$" + "${output}"} … while evaluating the attribute 'buildInputs' of the derivation 'gobject-introspection-1.74.0' … while calling 'getOutput' at /home/artturin/nixgits/my-nixpkgs/lib/attrsets.nix:827:23: 826| */ 827| getOutput = output: pkg: | ^ 828| if ! pkg ? outputSpecified || ! pkg.outputSpecified … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:228:13: 227| (map (drv: drv.__spliced.hostHost or drv) (checkDependencyList "depsHostHost" depsHostHost)) 228| (map (drv: drv.__spliced.hostTarget or drv) (checkDependencyList "buildInputs" buildInputs)) | ^ 229| ] … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/lib/lists.nix:117:29: 116| */ 117| imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list); | ^ 118| … from call site at /home/artturin/nixgits/my-nixpkgs/lib/lists.nix:117:32: 116| */ 117| imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list); | ^ 118| … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:199:81: 198| checkDependencyList = checkDependencyList' []; 199| checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep: | ^ 200| if lib.isDerivation dep || isNull dep || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep … from call site at /home/artturin/nixgits/my-nixpkgs/pkgs/stdenv/generic/make-derivation.nix:200:8: 199| checkDependencyList' = positions: name: deps: lib.flip lib.imap1 deps (index: dep: 200| if lib.isDerivation dep || isNull dep || builtins.typeOf dep == "string" || builtins.typeOf dep == "path" then dep | ^ 201| else if lib.isList dep then checkDependencyList' ([index] ++ positions) name dep … while calling 'isDerivation' at /home/artturin/nixgits/my-nixpkgs/lib/attrsets.nix:571:5: 570| # Value to check. 571| value: value.type or null == "derivation"; | ^ 572| … from call site at /home/artturin/nixgits/my-nixpkgs/pkgs/development/libraries/gobject-introspection/default.nix:84:6: 83| buildInputs = [ 84| (python3.withPackages pythonModules) | ^ 85| ]; … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/pkgs/development/interpreters/python/with-packages.nix:3:1: 2| 3| f: let packages = f pythonPackages; in buildEnv.override { extraLibs = packages; } | ^ 4| … from call site at /home/artturin/nixgits/my-nixpkgs/lib/trivial.nix:430:7: 429| { # TODO: Should we add call-time "type" checking like built in? 430| __functor = self: f; | ^ 431| __functionArgs = args; … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:88:32: 87| # Re-call the function but with different arguments 88| overrideArgs = copyArgs (newArgs: makeOverridable f (overrideWith newArgs)); | ^ 89| # Change the result of the function call by applying g to it … from call site at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:88:41: 87| # Re-call the function but with different arguments 88| overrideArgs = copyArgs (newArgs: makeOverridable f (overrideWith newArgs)); | ^ 89| # Change the result of the function call by applying g to it … while calling 'makeOverridable' at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:78:24: 77| */ 78| makeOverridable = f: origArgs: | ^ 79| let … from call site at /home/artturin/nixgits/my-nixpkgs/lib/trivial.nix:430:7: 429| { # TODO: Should we add call-time "type" checking like built in? 430| __functor = self: f; | ^ 431| __functionArgs = args; … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:90:54: 89| # Change the result of the function call by applying g to it 90| overrideResult = g: makeOverridable (copyArgs (args: g (f args))) origArgs; | ^ 91| … from call site at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:90:60: 89| # Change the result of the function call by applying g to it 90| overrideResult = g: makeOverridable (copyArgs (args: g (f args))) origArgs; | ^ 91| … while calling anonymous lambda at /home/artturin/nixgits/my-nixpkgs/lib/customisation.nix:111:29: 110| overrideAttrs = fdrv: 111| overrideResult (x: x.overrideAttrs fdrv); | ^ 112| } error: function 'anonymous lambda' called with unexpected argument 'extraLibs' at /home/artturin/nixgits/my-nixpkgs/pkgs/build-support/buildenv/default.nix:8:2: 7| lib.makeOverridable 8| ({ name | ^ 9|

…ngled-pname from NixOS#201734 (review)

This reverts commit a2cee1acda1f6a07ba2092147075f8812292acf5.

Artturin added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 18, 2022

Artturin requested a review from roberth November 18, 2022 06:07

Artturin requested review from winterqt, FRidh, fricklerhandwerk, Ericson2314, matthewbauer, edolstra, nbp and infinisil as code owners November 18, 2022 06:07

github-actions bot added 6.topic: kernel The Linux kernel 6.topic: python 6.topic: rust 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation labels Nov 18, 2022

Artturin commented Nov 18, 2022

View reviewed changes

lib/customisation.nix Outdated Show resolved Hide resolved

Artturin commented Nov 18, 2022

View reviewed changes

lib/customisation.nix Outdated Show resolved Hide resolved

Artturin requested a review from Mindavi November 18, 2022 06:17

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 18, 2022

roberth requested changes Nov 18, 2022

View reviewed changes

fricklerhandwerk reviewed Nov 18, 2022

View reviewed changes

doc/stdenv/cross-compilation.chapter.md Outdated Show resolved Hide resolved

github-actions bot removed the 6.topic: python label Nov 18, 2022

Artturin force-pushed the splicingstuff1 branch from ea481e8 to 1a44bd8 Compare November 18, 2022 16:44

Artturin force-pushed the splicingstuff1 branch from 1a44bd8 to 3b188e9 Compare November 18, 2022 22:05

roberth reviewed Dec 16, 2022

View reviewed changes

Artturin force-pushed the splicingstuff1 branch from 1c057d2 to 5b9bf35 Compare December 16, 2022 19:09

Artturin commented Dec 17, 2022

View reviewed changes

Artturin force-pushed the splicingstuff1 branch from b5d2d22 to 8dcf2d3 Compare December 17, 2022 23:08

github-actions bot removed the 6.topic: python label Dec 18, 2022

Artturin force-pushed the splicingstuff1 branch from 2b58588 to 30a0f5b Compare December 18, 2022 22:06

github-actions bot added the 6.topic: python label Dec 18, 2022

Artturin mentioned this pull request Jan 15, 2023

psycopg2: cross compilation fails again #210265

Closed

Artturin force-pushed the splicingstuff1 branch 2 times, most recently from 53f01cc to a2cee1a Compare January 15, 2023 04:09

Artturin commented Jan 15, 2023

View reviewed changes

roberth mentioned this pull request Jan 20, 2023

Fixes for overrideAttrs (split from #201734) #211685

Merged

13 tasks

Artturin marked this pull request as draft January 24, 2023 13:22

Artturin added a commit to Artturin/nixpkgs that referenced this pull request Jan 28, 2023

tests.overriding: add repeatedOverrides-pname, repeatedOverrides-enta…

a0f4e87

…ngled-pname from NixOS#201734 (review)

Artturin force-pushed the splicingstuff1 branch from f8f35c6 to 0678427 Compare March 1, 2023 20:03

github-actions bot removed 6.topic: python 6.topic: stdenv Standard environment labels Mar 1, 2023

Artturin added 4 commits March 1, 2023 22:04

fix splicing in overrideAttrs

6ba10ff

tests.splicing: add

f8af7e8

use overrideAttrs in makeOverridable

587301b

Revert "use overrideAttrs in makeOverridable"

65e3078

This reverts commit a2cee1acda1f6a07ba2092147075f8812292acf5.

Artturin force-pushed the splicingstuff1 branch from 0678427 to 65e3078 Compare March 1, 2023 20:04

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1-10 labels Mar 1, 2023

wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix splicing in overrideAttrs #201734

fix splicing in overrideAttrs #201734

Artturin commented Nov 18, 2022

roberth left a comment •

edited

Loading

roberth commented Nov 18, 2022

Artturin commented Nov 19, 2022

Artturin commented Nov 19, 2022 •

edited

Loading

roberth commented Nov 19, 2022

Artturin commented Nov 19, 2022

roberth Dec 16, 2022

Artturin commented Dec 16, 2022

Artturin Dec 17, 2022

roberth Dec 17, 2022

roberth Dec 17, 2022

Artturin Dec 17, 2022

Artturin Dec 18, 2022

roberth Dec 18, 2022

Artturin Dec 18, 2022

Artturin Dec 18, 2022 •

edited

Loading

Artturin Jan 15, 2023

Artturin Jan 15, 2023

Artturin Jan 15, 2023 •

edited by roberth

Loading

	// (lib.optionalAttrs (pkgsBuildHost ? ${name}) { nativeDrv = valueBuildHost; })
	// (lib.optionalAttrs (pkgsHostTarget ? ${name}) { crossDrv = valueHostTarget; })
	// {

fix splicing in overrideAttrs #201734

Are you sure you want to change the base?

fix splicing in overrideAttrs #201734

Conversation

Artturin commented Nov 18, 2022

Things done

roberth left a comment • edited Loading

Choose a reason for hiding this comment

roberth commented Nov 18, 2022

Artturin commented Nov 19, 2022

Artturin commented Nov 19, 2022 • edited Loading

roberth commented Nov 19, 2022

Artturin commented Nov 19, 2022

Choose a reason for hiding this comment

Artturin commented Dec 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Artturin Dec 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Artturin Jan 15, 2023 • edited by roberth Loading

Choose a reason for hiding this comment

roberth left a comment •

edited

Loading

Artturin commented Nov 19, 2022 •

edited

Loading

Artturin Dec 18, 2022 •

edited

Loading

Artturin Jan 15, 2023 •

edited by roberth

Loading