Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/backport-action 0.0.8 -> 0.0.9 #202500

Merged
merged 1 commit into from
Nov 27, 2022
Merged

workflows/backport-action 0.0.8 -> 0.0.9 #202500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/backport.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- name: Create backport PRs
uses: zeebe-io/backport-action@v0.0.8
uses: zeebe-io/backport-action@v0.0.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: zeebe-io/backport-action@v0.0.9
uses: zeebe-io/backport-action@2ee900dc92632adf994f8e437b6d16840fd61f58 # tag=v0.0.9

How do you feel about pinning the action to the specific commit?

This could help in the situation where the upstream repository of the action is compromised is some ways (especially since the job has some write permissions).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this has already been discussed in #140301, sorry for the noise and feel free to disregard my comment. Dependabot support has however been improved since then and updating the commit reference and the associated comment is not an issue anymore (see dependabot/dependabot-core#5951)

with:
# Config README: https://github.com/zeebe-io/backport-action#backport-action
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down