nixos/zfs: assert no force import with hibernation #203524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
Will try to review it soon, but @infinisil input at #171680 (comment) (sorry for not responding, busy with RL) maybe beter than mine here, he even suggest an approach that may prevent this type of thing happening. |
jakubgs
added a commit
to jakubgs/nixos-config
that referenced
this pull request
Dec 11, 2022
Related to: openzfs/zfs#12842 NixOS/nixpkgs#171680 NixOS/nixpkgs#203524 Signed-off-by: Jakub Sokołowski <jakub@status.im>
RaitoBezarius
approved these changes
Dec 17, 2022
According to a ZFS issue about hibernation causing data corruption: openzfs/zfs#12842 The way this happens is if the system force imports a pool that was suspended during hibernation. I've had this happen twice on NixOS and I'd like to avoid having this happen again, to me or others. To do this I've added an assertion that makes sure you can't have `forceImportRoot` or `forceImportAll` enabled with `allowHibernation`. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
zfs/no-force-import-hibernate
branch
from
6b20a2f to
c70f047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
According to a ZFS issue about hibernation causing data corruption:
The way this happens is if the system force imports a pool that was suspended during hibernation. I've had this happen twice on NixOS and I'd like to avoid having this happen again, to me or others.
To do this I've added an assertion that makes sure you can't have
forceImportRootorforceImportAllenabled withallowHibernation.Related:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes