Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladybird: fix build #203532

Merged
merged 1 commit into from
Nov 29, 2022
Merged

ladybird: fix build #203532

merged 1 commit into from
Nov 29, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 28, 2022 •
edited
Loading

Description of changes

#201254 #202015

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank wegank mentioned this pull request Nov 28, 2022
Merged
13 tasks
@ofborg ofborg bot requested a review from fgaz November 28, 2022 23:41
@fgaz
Copy link
Member

fgaz commented Nov 29, 2022

@wegank if there isn't anything missing, could you mark this as ready?

@wegank wegank marked this pull request as ready for review November 29, 2022 15:23
risicle
risicle approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixosTests.ladybird passes for me, x86_64 & aarch64.

Obviously can't test x86_64 darwin until the qt6 PR gets merged.

@risicle risicle merged commit 250c00d into NixOS:master Nov 29, 2022
@risicle
Copy link
Contributor

risicle commented Nov 29, 2022

Is the intention to backport this to 22.11?

@wegank wegank deleted the ladybird-fix branch November 29, 2022 22:12
@fgaz
Copy link
Member

fgaz commented Dec 2, 2022

I don't see why not

@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Successfully created backport PR #204079 for release-22.11.

@fgaz fgaz mentioned this pull request Jan 25, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco left review comments

@risicle risicle risicle approved these changes

@fgaz fgaz fgaz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wegank @fgaz @risicle @ElvishJerricco