llvm: disable libpfm on all non-Linux platforms #205355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libpfm is Linux-specific, it should be disabled on e.g. FreeBSD as well as Darwin.
alyssais
added
the
6.topic: portability
trofi
approved these changes
Dec 12, 2022
92 tasks
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Mar 24, 2023
this was applied to `llvmPackages_15` in 81ef82a (though I appear to have forgotten to mention it in the commit message...)
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Mar 24, 2023
this was applied to `llvmPackages_15` in 81ef82a (though I appear to have forgotten to mention it in the commit message...)
48 tasks
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Apr 3, 2023
this was applied to `llvmPackages_15` in 81ef82a (though I appear to have forgotten to mention it in the commit message...)
rrbutani
added a commit
to rrbutani/nixpkgs
that referenced
this pull request
Apr 5, 2023
this was applied to `llvmPackages_15` in 81ef82a (though I appear to have forgotten to mention it in the commit message...)
RaitoBezarius
added a commit
that referenced
this pull request
Apr 19, 2023
llvmPackages_git: apply #205355 (disable libpfm on non-Linux)
anpin
pushed a commit
to anpin/nixpkgs
that referenced
this pull request
Apr 22, 2023
this was applied to `llvmPackages_15` in 81ef82a (though I appear to have forgotten to mention it in the commit message...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
libpfm is Linux-specific, it should be disabled on e.g. FreeBSD as well as Darwin.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes