-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/version: Only warn about unset stateVersion if used (lite) #207958
nixos/version: Only warn about unset stateVersion if used (lite) #207958
Conversation
What about dropping the default altogether? |
The default default or the macOS one? The macOS linux builder one seems valuable enough because it adds a bit of explanation. I'm ok with removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few small suggestions
If a configuration does not use services that depend on the stateVersion, it does not need to be set. This provides an incentive for services not to rely on stateVersion, and not to burden users with this.
The `system` argument is usually implied, and not hard to figure out. Co-authored-by: Gabriella Gonzalez <Gabriel439@gmail.com>
I was considering the broader context of stateVersion, but the macos builder does not enable documentation, making this paragraph a distraction.
e213eae
to
91050a9
Compare
Description of changes
If a configuration does not use services that depend on the
stateVersion
, it does not need to be set.This provides an incentive for services not to rely on
stateVersion
, and not to burden users with this.Currently, it is still required by some modules, so to make a valid
stateVersion
-less configuration you'll have to usedisabledModules
.This change forms the foundation of #207313, which has breaking changes, while this pr does not.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes