check-meta.nix: use meta.availableOn #208686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates duplicated logic, and also enables the use of `lib.systems.inspect.patterns` patterns (from #37395) in `meta.badPlatforms`.
added 2 commits
January 1, 2023 16:16
Currently, `lib.meta.availableOn` will fail for packages which omit `meta.platforms` (e.g. `djbdns`). This commit avoids that failure.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ghost
marked this pull request as ready for review
ghost
requested review from
Ericson2314,
matthewbauer,
piegamesde,
edolstra,
nbp and
infinisil
as code owners
ghost
mentioned this pull request
2 tasks
|
Apparently I already submitted this, back in October: #195294 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This eliminates duplicated logic, and also enables the use of
lib.systems.inspect.patternspatterns (from #37395) inmeta.badPlatforms.This PR includes the changes in #208687.
Things done