Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensbi: 1.1 -> 1.2 #209120

Merged
merged 1 commit into from
Jan 19, 2023
Merged

opensbi: 1.1 -> 1.2 #209120

merged 1 commit into from
Jan 19, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jan 5, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • riscv64-linux (cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 5, 2023
@zhaofengli
Copy link
Member

Cool, it's been a while since I touched RISC-V stuff. Doing another round of rebuilds...

zhaofengli
zhaofengli approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@zhaofengli zhaofengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works on QEMU. Haven't tried booting the new U-Boot on real hardware yet.

@NickCao
Copy link
Member Author

NickCao commented Jan 14, 2023

Haven't got my hands wet on visionfive2 either, currently asking my friends to test it for me.

@NickCao NickCao merged commit 3836bf0 into NixOS:master Jan 19, 2023
@NickCao NickCao deleted the opensbi branch January 19, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaofengli zhaofengli zhaofengli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCao @zhaofengli