Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: use meta.availableOn to pick luajit/lua5_1 #209141

Merged
merged 2 commits into from Jan 6, 2023
Merged

lua: use meta.availableOn to pick luajit/lua5_1 #209141

merged 2 commits into from Jan 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2023

Description of changes

This PR has two commits which:

  1. Add powerpc64le-linux to luajit.meta.badPlatforms

  2. Use meta.availableOn in top-level/all-packages.nix to decide whether or not to use luajit as the Lua implementation, instead of duplicating the logic already present in luajit.meta.badPlatforms

Things done

@ghost ghost mentioned this pull request Jan 5, 2023
3 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 5, 2023
@ghost
Copy link
Author

ghost commented Jan 5, 2023

@ofborg eval

darwin builders stuck again

@Mindavi Mindavi merged commit f605337 into NixOS:master Jan 6, 2023
@ghost ghost deleted the lua/powerpc-availableon branch January 7, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lua 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants