Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsForQt5.qca-qt5: unbreak on darwin #209801

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 9, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 9, 2023
@thiagokokada thiagokokada merged commit ebf9e98 into NixOS:master Jan 9, 2023
@wegank wegank deleted the qca-qt5-darwin branch January 9, 2023 11:10
@imincik
Copy link
Contributor

imincik commented Jan 11, 2023

@wegank , @thiagokokada what is the actual change which makes qca-qt5 working on darwin again ?

@thiagokokada
Copy link
Contributor

@wegank , @thiagokokada what is the actual change which makes qca-qt5 working on darwin again ?

I am assuming that we are building Qt 5.15 in darwin now?

@imincik
Copy link
Contributor

imincik commented Jan 11, 2023

Great thanks !

@imincik
Copy link
Contributor

imincik commented Jan 11, 2023

@lsix @sikmir @erictapen @willcohen - chance to get QGIS on darwin ?

@willcohen
Copy link
Contributor

Yes! Two days ago I dusted off #157862 and locally rebased to master (I'm not pushing to the branch so I don't keep spamming darwin-maintainers just yet). Right now I'm at the highly annoying stage of getting all the dylibs to link correctly by manually running install_name_tool on every combination of every dylib being referred to from all the random frameworks, but every time I fix one link error I've gotta re-run the whole build, so it's slow going. I hope in the next couple of days that I finally get through it all and can get it to load.

As soon as QGIS actually builds and starts up I'll push the branch and we can hopefully merge that without much fuss. My preference would be to move all the fine-tuning to later PRs -- there's a strong chance that there'll still be little breakages with the various components, but getting something going is better than waiting for every little bit to be ironed out.

@imincik
Copy link
Contributor

imincik commented Jan 11, 2023

Great thanks @willcohen .

@willcohen
Copy link
Contributor

@imincik any suggestions of how to proceed further based on #157862 (comment) would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants