lib/path/tests: Fix property tests when "-n" is generated #210042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "-n" is generated by the property tests, it causes `echo` to not output the string since it's interpreted as an option. Apparently there's no good way to print "-n" with `echo` [1], so switching to `printf` instead [1]: https://unix.stackexchange.com/questions/85846/how-can-i-print-n-with-echo
3 tasks
vcunat
approved these changes
Jan 10, 2023
ofborg
bot
added
10.rebuild-darwin: 0
|
You should use |
|
I don't think so, from docs or test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When "-n" is generated by the property tests, it causes
echoto not output the string since it's interpreted as an option. Apparently there's no good way to print "-n" withecho, so switching toprintfinsteadThanks to @vcunat for reporting the original failure in the PR that introduced it
I love this, while the property tests didn't detect a mistake in the code implementation, they did detect a mistake in the test implementation!
This work is sponsored by Antithesis ✨
Things done
lib/path/tests/prop.sh 13110