Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eunomia-cc: init at 1.0.11 #212119

Merged
merged 1 commit into from
Oct 8, 2023
Merged

eunomia-cc: init at 1.0.11 #212119

merged 1 commit into from
Oct 8, 2023

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Jan 22, 2023 •
edited
Loading

Description of changes

An CO-RE compile set to help you focus on writing a single eBPF program in the kernel.
A part of the eunomia-bpf project, a compiler and runtime framework for building, distributing and running CO-RE eBPF programs in multi-languages and Webassembly.

https://github.com/eunomia-bpf/eunomia-bpf

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@oluceps oluceps marked this pull request as ready for review January 22, 2023 14:30
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 22, 2023
@oluceps oluceps changed the title eunomia-cc: init at 0.3.1 eunomia-cc: init at 0.3.2 Jan 31, 2023
ocfox
ocfox approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@ocfox ocfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 5, 2023
@doronbehar
Copy link
Contributor

@ofborg eval

@doronbehar
Copy link
Contributor

@oluceps this looks good overall, but ofborg complains about something with llvmPackages_latest, would you like to fix it?

@oluceps
Copy link
Member Author

oluceps commented Sep 5, 2023

Still alive. I'll upgrade this pr in a little while.

@oluceps oluceps changed the title eunomia-cc: init at 0.3.2 eunomia-cc: init at 1.0.10 Oct 2, 2023
doronbehar
doronbehar reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more general thing, try to use finalAttrs when using stdenv.mkDerivation, it will make it easier to override this package.

pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
@oluceps oluceps force-pushed the add-ecc branch 3 times, most recently from 37a0b49 to 0b29978 Compare October 3, 2023 14:39
@oluceps oluceps marked this pull request as draft October 3, 2023 15:54
@oluceps
Copy link
Member Author

oluceps commented Oct 3, 2023

Current changes require eunomia-bpf/eunomia-bpf#308 to be merged first.

@oluceps oluceps force-pushed the add-ecc branch 2 times, most recently from f922a4d to efa488d Compare October 5, 2023 12:47
@oluceps oluceps changed the title eunomia-cc: init at 1.0.10 eunomia-cc: init at 1.0.11 Oct 5, 2023
@oluceps oluceps marked this pull request as ready for review October 5, 2023 12:47
@oluceps
Copy link
Member Author

oluceps commented Oct 5, 2023

Current changes require eunomia-bpf/eunomia-bpf#308 to be merged first.

Merged.

You should consider using rustPlatform.buildRustPackage.

This is done as well.

doronbehar
doronbehar reviewed Oct 5, 2023
View reviewed changes
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
@oluceps oluceps force-pushed the add-ecc branch 2 times, most recently from 4b5a93f to fe2cb80 Compare October 5, 2023 17:36
doronbehar
doronbehar reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! This begins to take good form.

pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/eunomia-bpf/eunomia-cc/default.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor

doronbehar commented Oct 8, 2023 •
edited
Loading

One more last thing @oluceps we couldn't have detected before - the aarch64-linux build fails. You can try to fix that, and use ofborg to build on aarch64-linux, or you can add a broken = stdenv.isAarch64;.

If you want to use ofborg (some people don't know that), use:

@ofborg build ecc

@oluceps @doronbehar
ecc: init at 1.0.11
8d14f6d 
Co-authored-by: doronbehar <doron.behar@gmail.com>
@oluceps
Copy link
Member Author

oluceps commented Oct 8, 2023

@ofborg build ecc

@doronbehar doronbehar merged commit d262a35 into NixOS:master Oct 8, 2023
24 of 26 checks passed
@oluceps oluceps deleted the add-ecc branch October 8, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@ocfox ocfox ocfox approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oluceps @doronbehar @ocfox @figsoda