rav1e: use libgit2 from Nixpkgs #212597
Merged
rav1e: use libgit2 from Nixpkgs #212597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
added
the
6.topic: cross-compilation
This is a native build input because it's used at build time by the "built" crate, which tries to embed git info and build timestamps into the binary (ugh). This fixes cross-compilation from x86_64 to aarch64, because git2's build.rs tries to use -m64, which is x86_64-only.
|
@ofborg eval |
|
Confirms this fixes cross build from x86_64-linux to riscv64-linux too. |
|
@ofborg build pkgsCross.aarch64-multiplatform.rav1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a native build input because it's used at build time by the "built" crate, which tries to embed git info and build timestamps into the binary (ugh).
This fixes cross-compilation from x86_64 to aarch64, because git2's build.rs tries to use -m64, which is x86_64-only.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes