python3Packages.riscof: init 1.25.2

[GenericNerdyUsername]

Description of changes

Add riscof (and dependencies)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

Relevant: #213222

[Et7f3]

Did you applied suggestion on the other PR ?

[GenericNerdyUsername]

Yup

[NickCao]

Quite a lot formatting and code style issues. You can use nixpkgs-format, statix and other tools you help you locate/fix these issues.

[GenericNerdyUsername]

All the problems mentioned in the review should be fixed now

[GenericNerdyUsername]

Assuming fixing the merge conflict didn't break anything, I think this is ready to merge (unless there's something in the review i missed?)

[NickCao]

looks good to my eye, just need someone who knows the ocaml ecosystem better than me to take a second look.

[NickCao]

@vbgl sorry for pinging you without asking for permission, but you seem to be working with ocaml things recently and I hope to get a review from you.

[vbgl]

No problem. I’ll try to give a look at the OCaml parts of this PR.

[vbgl]

Most of the comments/suggestion also apply to the linksem library.

[GenericNerdyUsername]

@vbgl can you check if i missed any of your recommendations?

[GenericNerdyUsername]

Done

[NickCao]

Result of nixpkgs-review pr 213832 run on x86_64-linux 1

20 packages built:

• python310Packages.dataproperty
• python310Packages.mbstrdecoder
• python310Packages.pytablewriter
• python310Packages.riscof
• python310Packages.riscv-config
• python310Packages.riscv-isac
• python310Packages.tabledata
• python310Packages.tcolorpy
• python310Packages.typepy
• python311Packages.dataproperty
• python311Packages.mbstrdecoder
• python311Packages.pytablewriter
• python311Packages.riscof
• python311Packages.riscv-config
• python311Packages.riscv-isac
• python311Packages.tabledata
• python311Packages.tcolorpy
• python311Packages.typepy
• sail-riscv-rv32
• sail-riscv-rv64

[NickCao]

@GenericNerdyUsername thanks for your contribution and patience in addressing review comments.
@vbgl also thanks for your review.