fusesoc: init at 1.12.0 #215001

GenericNerdyUsername · 2023-02-06T21:31:10Z

Description of changes

Add fusesoc (and dependencies)

Things done

Relevant: #213222

Alizter · 2023-03-26T03:00:10Z

Result of nixpkgs-review pr 215001 run on x86_64-linux 1

4 packages failed to build:

python310Packages.fusesoc
python310Packages.fusesoc.dist
python311Packages.fusesoc
python311Packages.fusesoc.dist

16 packages built:

python310Packages.ipyxact
python310Packages.ipyxact.dist
python310Packages.okonomiyaki
python310Packages.okonomiyaki.dist
python310Packages.simplesat
python310Packages.simplesat.dist
python310Packages.zipfile2
python310Packages.zipfile2.dist
python311Packages.ipyxact
python311Packages.ipyxact.dist
python311Packages.okonomiyaki
python311Packages.okonomiyaki.dist
python311Packages.simplesat
python311Packages.simplesat.dist
python311Packages.zipfile2
python311Packages.zipfile2.dist

GenericNerdyUsername · 2023-03-26T10:51:50Z

Should be fixed now

Alizter · 2023-03-26T11:11:31Z

Result of nixpkgs-review pr 215001 run on x86_64-linux 1

25 packages built:

python310Packages.edalize
python310Packages.edalize.dist
python310Packages.fusesoc
python310Packages.fusesoc.dist
python310Packages.ipyxact
python310Packages.ipyxact.dist
python310Packages.okonomiyaki
python310Packages.okonomiyaki.dist
python310Packages.simplesat
python310Packages.simplesat.dist
python310Packages.zipfile2
python310Packages.zipfile2.dist
python311Packages.edalize
python311Packages.edalize.dist
python311Packages.fusesoc
python311Packages.fusesoc.dist
python311Packages.ipyxact
python311Packages.ipyxact.dist
python311Packages.okonomiyaki
python311Packages.okonomiyaki.dist
python311Packages.simplesat
python311Packages.simplesat.dist
python311Packages.zipfile2
python311Packages.zipfile2.dist
silice

astro · 2023-03-26T12:24:09Z

pkgs/top-level/python-packages.nix

@@ -3725,6 +3725,8 @@ self: super: with self; {

  fusepy = callPackage ../development/python-modules/fusepy { };

+  fusesoc = callPackage ../development/python-modules/fusesoc { };


As this is an end-user program, not a library, it might be preferably exported from pkgs/top-level/all-packages.nix

What about in pkgs/top-level/aliases.nix? That way people can use the python311 version if they need to for whatever reason.

A user of the application shouldn't care what version of the language the application is using. all-packages.nix is the right place for this.

Relevant manual section

im assuming i should remove it from here as well?

What about in pkgs/top-level/aliases.nix? That way people can use the python311 version if they need to for whatever reason.

New names should not be directly added to aliases

SuperSandro2000

You are missing pythonImportsCheck in lots of places.
For tests please use pytestCheckHook if possible.

SuperSandro2000 · 2023-04-26T23:01:45Z

pkgs/top-level/python-packages.nix

@@ -3725,6 +3725,8 @@ self: super: with self; {

  fusepy = callPackage ../development/python-modules/fusepy { };

+  fusesoc = callPackage ../development/python-modules/fusesoc { };


What about in pkgs/top-level/aliases.nix? That way people can use the python311 version if they need to for whatever reason.

New names should not be directly added to aliases

pkgs/development/python-modules/simplesat/default.nix

pkgs/development/python-modules/okonomiyaki/default.nix

SuperSandro2000 · 2023-04-26T23:13:03Z

pkgs/development/python-modules/fusesoc/default.nix

+  pname = "fusesoc";
+  version = "1.12.0";
+
+  propagatedBuildInputs = [ edalize pyparsing pyyaml simplesat ipyxact verilog verilator gnumake gcc ];


Why do we propagate make and gcc?

It needs them to be in the path at runtime

Then propagatedNativeBuildInputs should be used but can we instead patch the code or use a wrapper?

pkgs/top-level/all-packages.nix

GenericNerdyUsername · 2023-04-27T13:23:36Z

Should I update fusesoc now, or is that a job for a different pr?

SuperSandro2000 · 2023-05-04T21:27:05Z

Also please rebase

GenericNerdyUsername · 2023-05-05T20:40:44Z

Turns out gcc isnt needed, and that the edalize update in between rebases broke the old version, so I updated fusesoc

SuperSandro2000 · 2023-05-06T18:53:15Z

pkgs/development/python-modules/okonomiyaki/default.nix

+  propagatedBuildInputs = [ distro attrs jsonschema six zipfile2 ];
+
+  postPatch = ''
+    substituteInPlace /build/source/okonomiyaki/runtimes/tests/test_runtime.py \


substitute(): ERROR: file '/build/source/okonomiyaki/runtimes/tests/test_runtime.py' does not exist

This is still an erorr

both nix build .#python310Packages.okonomiyaki .#python311Packages.okonomiyaki and nixpkgs-review rev 215001 cant reproduce this, what command are you running to build? Did nix cache a broken source tree perhaps?

This if from the darwin ofborg check below and I just noticed why this is broken.

Did nix cache a broken source tree perhaps?

It can't there is no cache for the CI checks.

we can't use an absolute path here

Suggested change

substituteInPlace /build/source/okonomiyaki/runtimes/tests/test_runtime.py \

substituteInPlace okonomiyaki/runtimes/tests/test_runtime.py \

pkgs/tools/package-management/fusesoc/default.nix

GenericNerdyUsername · 2023-05-06T21:28:50Z

done

pkgs/development/python-modules/okonomiyaki/default.nix

GenericNerdyUsername requested review from FRidh and jonringer as code owners February 6, 2023 21:31

github-actions bot added the 6.topic: python label Feb 6, 2023

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 6, 2023

GenericNerdyUsername force-pushed the fusesoc branch 2 times, most recently from 18df485 to 6fa9eb0 Compare February 16, 2023 21:06

GenericNerdyUsername force-pushed the fusesoc branch from 6fa9eb0 to d0eb8de Compare March 25, 2023 19:57

GenericNerdyUsername force-pushed the fusesoc branch from d0eb8de to c63b297 Compare March 26, 2023 10:51

ofborg bot requested a review from astro March 26, 2023 11:24

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 26, 2023

astro suggested changes Mar 26, 2023

View reviewed changes

GenericNerdyUsername force-pushed the fusesoc branch from c63b297 to 83a9f85 Compare April 5, 2023 13:29

ofborg bot requested a review from astro April 5, 2023 14:14

GenericNerdyUsername force-pushed the fusesoc branch 2 times, most recently from 3087d6c to 9b7e3e4 Compare April 26, 2023 23:09

SuperSandro2000 requested changes Apr 26, 2023

View reviewed changes

GenericNerdyUsername force-pushed the fusesoc branch from 9b7e3e4 to 77791de Compare April 27, 2023 13:20

GenericNerdyUsername force-pushed the fusesoc branch from 77791de to f44e95f Compare May 5, 2023 20:30

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 5, 2023

SuperSandro2000 reviewed May 6, 2023

View reviewed changes

pkgs/tools/package-management/fusesoc/default.nix Outdated Show resolved Hide resolved

pkgs/tools/package-management/fusesoc/default.nix Outdated Show resolved Hide resolved

GenericNerdyUsername force-pushed the fusesoc branch from f44e95f to 098fad8 Compare May 6, 2023 21:28

GenericNerdyUsername force-pushed the fusesoc branch from 098fad8 to c766fe4 Compare May 7, 2023 19:00

SuperSandro2000 reviewed May 7, 2023

View reviewed changes

pkgs/development/python-modules/okonomiyaki/default.nix Show resolved Hide resolved

GenericNerdyUsername force-pushed the fusesoc branch from c766fe4 to 4201645 Compare May 13, 2023 14:03

SuperSandro2000 reviewed May 21, 2023

View reviewed changes

pkgs/development/python-modules/okonomiyaki/default.nix Outdated Show resolved Hide resolved

aacebedo and others added 6 commits May 21, 2023 18:42

nordic: unstable-2022-06-21 -> unstable-2023-05-12

dc1813f

python3Packages.ipyxact: init at 0.3.2

a83a359

python3Packages.zipfile2: init at 0.0.12

82a7b27

python3Pacakges.okonomiyaki: init at 1.3.2

601006e

python3Packages.simplesat: init at 0.8.2

286e27c

fusesoc: init at 2.2.1

1ff2248

SuperSandro2000 force-pushed the fusesoc branch from f5069bd to 1ff2248 Compare May 21, 2023 16:43

SuperSandro2000 approved these changes May 21, 2023

View reviewed changes

SuperSandro2000 merged commit ddf8259 into NixOS:master May 21, 2023

GenericNerdyUsername deleted the fusesoc branch May 23, 2023 11:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fusesoc: init at 1.12.0 #215001

fusesoc: init at 1.12.0 #215001

GenericNerdyUsername commented Feb 6, 2023

Alizter commented Mar 26, 2023

GenericNerdyUsername commented Mar 26, 2023

Alizter commented Mar 26, 2023

astro Mar 26, 2023

GenericNerdyUsername Mar 26, 2023

alyssais Apr 26, 2023

GenericNerdyUsername Apr 26, 2023

SuperSandro2000 Apr 26, 2023

SuperSandro2000 left a comment

SuperSandro2000 Apr 26, 2023

SuperSandro2000 Apr 26, 2023

GenericNerdyUsername Apr 27, 2023

SuperSandro2000 May 4, 2023

GenericNerdyUsername commented Apr 27, 2023

SuperSandro2000 commented May 4, 2023

GenericNerdyUsername commented May 5, 2023

SuperSandro2000 May 6, 2023

SuperSandro2000 May 7, 2023

GenericNerdyUsername May 7, 2023 •

edited

Loading

SuperSandro2000 May 7, 2023

GenericNerdyUsername commented May 6, 2023

		@@ -3725,6 +3725,8 @@ self: super: with self; {

		fusepy = callPackage ../development/python-modules/fusepy { };

		fusesoc = callPackage ../development/python-modules/fusesoc { };

	substituteInPlace /build/source/okonomiyaki/runtimes/tests/test_runtime.py \
	substituteInPlace okonomiyaki/runtimes/tests/test_runtime.py \

fusesoc: init at 1.12.0 #215001

fusesoc: init at 1.12.0 #215001

Conversation

GenericNerdyUsername commented Feb 6, 2023

Description of changes

Things done

Alizter commented Mar 26, 2023

GenericNerdyUsername commented Mar 26, 2023

Alizter commented Mar 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GenericNerdyUsername commented Apr 27, 2023

SuperSandro2000 commented May 4, 2023

GenericNerdyUsername commented May 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GenericNerdyUsername May 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GenericNerdyUsername commented May 6, 2023

GenericNerdyUsername May 7, 2023 •

edited

Loading