Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

legdur: init at 0.3.0 #215172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

legdur: init at 0.3.0 #215172

wants to merge 1 commit into from
+30 −0

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Feb 7, 2023 •
edited
Loading

Description of changes

Add legdur to nixpkgs

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F changed the title legur: init at 0.3.0 legdur: init at 0.3.0 Feb 7, 2023
@0x4A6F 0x4A6F force-pushed the master-legdur branch 2 times, most recently from b81cc4b to e13c5db Compare February 7, 2023 18:35
azahi
azahi requested changes Feb 11, 2023
View reviewed changes
pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
0x4A6F
0x4A6F commented Feb 11, 2023
View reviewed changes
Copy link
Member Author

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you feedback.

pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/legdur/default.nix Show resolved Hide resolved
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azahi azahi azahi approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x4A6F @azahi @wegank