Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshroom #216403

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Meshroom #216403

wants to merge 2 commits into from

Conversation

hesiod
Copy link
Contributor

@hesiod hesiod commented Feb 15, 2023

Description of changes

Preliminary PR, depends on (and contains) the following PRs:

Fixes #94127.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hesiod
Copy link
Contributor Author

hesiod commented Feb 15, 2023

@davidak I went ahead and created a preliminary PR for Meshroom since I figured you might be interested in the final product. Meshroom itself should work fine with this PR (unless I messed something in this PR during rebasing).

@davidak
Copy link
Member

davidak commented Feb 15, 2023

Result of nixpkgs-review pr 216403 run on x86_64-linux 1

18 packages marked as broken and skipped:
  • gimpPlugins.exposureBlend
  • octavePackages.fem-fenics
  • octavePackages.octproj
  • octavePackages.vibes
  • octavePackages.vrml
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-optimization
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-optimization
92 packages failed to build:
  • alice-vision
  • blender
  • blender-hip
  • cctag
  • cholmod-extra
  • gama
  • gimp-with-plugins
  • gimpPlugins.gmic
  • gnome-photos
  • librsb
  • meshroom
  • minc_widgets
  • octave
  • octaveFull
  • octavePackages.arduino
  • octavePackages.audio
  • octavePackages.bim
  • octavePackages.bsltl
  • octavePackages.cgi
  • octavePackages.communications
  • octavePackages.control
  • octavePackages.data-smoothing
  • octavePackages.database
  • octavePackages.dataframe
  • octavePackages.dicom
  • octavePackages.divand
  • octavePackages.doctest
  • octavePackages.econometrics
  • octavePackages.financial
  • octavePackages.fits
  • octavePackages.fpl
  • octavePackages.fuzzy-logic-toolkit
  • octavePackages.ga
  • octavePackages.general
  • octavePackages.generate_html
  • octavePackages.geometry
  • octavePackages.gsl
  • octavePackages.image
  • octavePackages.image-acquisition
  • octavePackages.instrument-control
  • octavePackages.interval
  • octavePackages.io
  • octavePackages.level-set
  • octavePackages.linear-algebra
  • octavePackages.lssa
  • octavePackages.ltfat
  • octavePackages.mapping
  • octavePackages.matgeom
  • octavePackages.miscellaneous
  • octavePackages.msh
  • octavePackages.mvn
  • octavePackages.nan
  • octavePackages.ncarray
  • octavePackages.netcdf
  • octavePackages.nurbs
  • octavePackages.ocl
  • octavePackages.octclip
  • octavePackages.optics
  • octavePackages.optim
  • octavePackages.optiminterp
  • octavePackages.parallel
  • octavePackages.quaternion
  • octavePackages.queueing
  • octavePackages.signal
  • octavePackages.sockets
  • octavePackages.sparsersb
  • octavePackages.splines
  • octavePackages.statistics
  • octavePackages.stk
  • octavePackages.strings
  • octavePackages.struct
  • octavePackages.symbolic
  • octavePackages.tisean
  • octavePackages.tsa
  • octavePackages.video
  • octavePackages.windows
  • octavePackages.zeromq
  • openems
  • python310Packages.bpycv
  • python310Packages.opensfm
  • python310Packages.python-csxcad
  • python310Packages.python-openems
  • python310Packages.qutip
  • python310Packages.scikit-survival
  • python311Packages.cvxpy
  • python311Packages.opensfm
  • python311Packages.python-csxcad
  • python311Packages.python-openems
  • python311Packages.qutip
  • python311Packages.scikit-survival
  • rtabmap
  • tbb_2021_8
46 packages built:
  • alembic
  • ceres-solver
  • colmap
  • colmapWithCuda
  • g2o
  • gegl
  • geogram
  • gimp (gimpPlugins.gimp)
  • gimpPlugins.bimp
  • gimpPlugins.farbfeld
  • gimpPlugins.fourier
  • gimpPlugins.gap
  • gimpPlugins.gimplensfun
  • gimpPlugins.lightning
  • gimpPlugins.lqrPlugin
  • gimpPlugins.resynthesizer
  • gimpPlugins.texturize
  • gimpPlugins.waveletSharpen
  • hal-hardware-analyzer
  • openmvs
  • openturns
  • python310Packages.cvxopt
  • python310Packages.cvxpy
  • python310Packages.fenics
  • python310Packages.openturns
  • python310Packages.osqp
  • python310Packages.picos
  • python310Packages.pot
  • python310Packages.scikits-odes
  • python311Packages.cvxopt
  • python311Packages.fenics
  • python311Packages.openturns
  • python311Packages.osqp
  • python311Packages.picos
  • python311Packages.scikits-odes
  • sage
  • sageWithDoc
  • suitesparse (suitesparse_5_3)
  • sundials
  • tbb_2020_3
  • toppler
  • trilinos
  • trilinos-mpi
  • xfitter
  • xyce
  • xyce-parallel

@hesiod
Copy link
Contributor Author

hesiod commented Feb 15, 2023

@davidak Interesting - most of the broken packages probably boil down to the failed build of tbb_2021_8 (which is part of the TBB PR #215689). I'm a little surprised it doesn't build, perhaps I did indeed break something while rebasing yesterday.

@davidak
Copy link
Member

davidak commented Feb 15, 2023

most of the broken packages probably boil down to the failed build of tbb_2021_8

it also leads meshroom to fail

error: builder for '/nix/store/jx0yhzs4ff1kdbfk5nblphrw60z8fsb6-tbb-2021.8.0.drv' failed with exit code 2;
last 10 log lines:
> cc1plus: all warnings being treated as errors
> make[2]: *** [test/CMakeFiles/test_concurrent_lru_cache.dir/build.make:76: test/CMakeFiles/test_concurrent_lru_cache.dir/tbb/test_concurrent_lru_cache.cpp.o] Error 1
> make[1]: *** [CMakeFiles/Makefile2:700: test/CMakeFiles/test_concurrent_lru_cache.dir/all] Error 2
> [ 22%] Linking CXX executable ../gnu_12.2_cxx11_64_release/test_dynamic_link
> [ 22%] Built target test_dynamic_link
> [ 23%] Linking CXX executable ../gnu_12.2_cxx11_64_release/test_malloc_overload
> [ 24%] Linking CXX executable ../gnu_12.2_cxx11_64_release/test_malloc_pools
> [ 24%] Built target test_malloc_overload
> [ 24%] Built target test_malloc_pools
> make: *** [Makefile:166: all] Error 2
For full logs, run 'nix log /nix/store/jx0yhzs4ff1kdbfk5nblphrw60z8fsb6-tbb-2021.8.0.drv'.
error: 1 dependencies of derivation '/nix/store/0qw3pbxsrhf4pgcypi6dvq8b6gazgb6p-cctag-1.0.3.drv' failed to build
error: 1 dependencies of derivation '/nix/store/hp187ny2qvd6ng37ab96vknmi82qnb69-alice-vision-unstable-2023-02-07.drv' failed to build
error: 1 dependencies of derivation '/nix/store/2a30p63sgs9zibaf14qyb3sxkw3hapnz-qtalicevision-unstable-2023-01-18.drv' failed to build
error: 2 dependencies of derivation '/nix/store/n3ay3v5bp3ia3yxpnqxblvqfzq7b61pd-meshroom-unstable-2023-02-09.drv' failed to build

here you get the full log, with color: curl https://termbin.com/d4nh

i'm also debugging the blocking python tests issue

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 17, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Apr 2, 2023
@luzpaz luzpaz mentioned this pull request Jan 21, 2024
12 tasks
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Meshroom
3 participants