gst_all_1.gst-plugins-good: fix building rpicamsrc #217085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
vikanezrimaya
approved these changes
Feb 22, 2023
figsoda
added
the
12.approvals: 1
rpicamsrc is supported on 32-bit ARM as well, but this was not allowed by the assertion.
The build script is unable to find the libraspberrypi libraries unless explicitly told their location.
lopsided98
force-pushed
the
gstreamer-rpicamsrc
branch
from
b6ba4b0
to
51ce6b7
Compare
|
I fixed the conflicts. |
lilyinstarlight
approved these changes
Jul 26, 2023
MMAL is not supported on 64-bit (see [1]), so rpicamsrc cannot be built on aarch64. [1] raspberrypi/userland#688
lopsided98
force-pushed
the
gstreamer-rpicamsrc
branch
from
51ce6b7
to
d6fe182
Compare
lilyinstarlight
approved these changes
Jul 27, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
An assertion was preventing
raspiCameraSupportfrom being enabled on 32-bit ARM, and the build was failing because it needs to be told where to findlibraspberrypi.Later, I also realized that
rpicamsrcis actually not supported on aarch64, because the MMAL libraries inlibraspberrypidon't support aarch64. I believe there was a period of time where MMAL could be built on aarch64, which led to this code in nixpkgs, but this support was removed upstream because it was buggy (see raspberrypi/userland#688).I tested that
rpicamsrcworks on a Raspberry Pi Zero.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usagecc @vikanezrimaya @nh2