Typing stubs for home-assistant type checks #217763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
hass-stubs
branch
4 times, most recently
from
44f5456 to
6eb1f9b
Compare
dotlambda
reviewed
Feb 22, 2023
| @@ -4378,6 +4378,8 @@ self: super: with self; { | |||
|
|
|||
| homeassistant-pyozw = callPackage ../development/python-modules/homeassistant-pyozw { }; | |||
|
|
|||
| homeassistant-stubs = callPackage ../servers/home-assistant/stubs.nix { }; | |||
There was a problem hiding this comment.
I'd put it in
Suggested change
| homeassistant-stubs = callPackage ../servers/home-assistant/stubs.nix { }; | |
| homeassistant-stubs = callPackage ../development/python-modues/homeassistant-stubs { }; |
There was a problem hiding this comment.
I have a slight preference for keeping home-assistant packages more tightly grouped together, but not a strong opinion either.
mweinelt
force-pushed
the
hass-stubs
branch
2 times, most recently
from
c1ace78 to
5997e3a
Compare
ofborg
bot
added
11.by: package-maintainer
Typing hints for the voluptuous package.
Typing hints for Home Assistant core. Freshly generated out of our home-assistant package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our home-assistant package.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)