Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: fix implication order in assertion #217977

Merged
merged 1 commit into from Feb 25, 2023
Merged

gcc: fix implication order in assertion #217977

merged 1 commit into from Feb 25, 2023

Commits on Feb 24, 2023

  1. gcc: fix implication order in assertion

    In 6812dd9 I mistakenly had the
    implication order reversed.  This commit corrects that mistake.
    
    The original assertion (which is correct) was the following, which
    asserts that if you enable the GDB plugin, you must enable plugins
    generally (there is shared infrastructure):
    
    ```
    assert enableGdbPlugin -> enablePlugin;
    ```
    
    When the option name was changed to `disableGdbPlugin`, I
    incorrectly wrote:
    
    ```
    assert disableGdbPlugin -> enablePlugin;
    ```
    
    And then again incorrectly wrote:
    
    ```
    assert disableGdbPlugin -> !enablePlugin;
    ```
    
    This commit uses the correct equivalent for the first statement,
    which is the contrapositive:
    
    ```
    assert !enablePlugin -> disableGdbPlugin;
    ```
    Adam Joseph committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    86a0e46 View commit details
    Browse the repository at this point in the history