Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc/{11,12}: use lib.pipe #217981

Closed
wants to merge 1 commit into from
Closed

gcc/{11,12}: use lib.pipe #217981

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2023

Description of changes

This commit has no effect on eval. It simply reorganizes the gcc11 and gcc12 expressions so they apply a list of overrideAttrs. The list is currently empty.

Cc: @trofi

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

gcc/{11,12}: use lib.pipe
a363bb3 
This commit has no effect on eval.  It simply reorganizes the
`gcc11` and `gcc12` expressions so they apply a list of
`overrideAttrs`.  The list is currently empty.
@ghost ghost requested a review from matthewbauer as a code owner February 24, 2023 07:30
@ghost ghost mentioned this pull request Feb 24, 2023
Merged
4 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Feb 24, 2023
trofi
trofi suggested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Now that I looked at pipe definition) These changes are small enough to be present as part of actual changes applied to gcc expression. I would say no need for a separate PR for them (unless someone else requested for it as well).

@ghost ghost closed this Feb 25, 2023
@ghost ghost deleted the pr/gcc/lib-pipe branch January 23, 2024 06:48
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trofi