Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove -lgcc from NIX_LDFLAGS #219425

Merged
merged 12 commits into from
Mar 6, 2023
Merged

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 3, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member

NickCao commented Mar 4, 2023

Isn't the underlying issue supposed to be addressed in #209870 (which hasn't been merged?)

@wegank
Copy link
Member Author

wegank commented Mar 4, 2023

The issue has been temporarily resolved via a bootstrap file update (#207135).

Of course, #209870 is still needed to fully resolve #201254, as the issue may occur in a different form in future GCC updates.

@wegank wegank marked this pull request as draft March 4, 2023 09:51
@wegank wegank changed the base branch from staging to staging-next March 4, 2023 09:52
@wegank wegank marked this pull request as ready for review March 4, 2023 09:52
@wegank
Copy link
Member Author

wegank commented Mar 4, 2023

Rebased against staging-next.

@K900 K900 merged commit 2fe3640 into NixOS:staging-next Mar 6, 2023
@wegank wegank deleted the gcc12-cleanup branch March 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants