Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/firewall: handle conntrack helper autodetection being removed in 6.0 #219455

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

K900
Copy link
Contributor

@K900 K900 commented Mar 4, 2023

Description of changes

Upstream change: https://lore.kernel.org/all/20220830153319.71890-1-pablo@netfilter.org/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900 K900 added the 1.severity: channel blocker Blocks a channel label Mar 4, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 4, 2023
@vcunat
Copy link
Member

vcunat commented Mar 4, 2023

I'd say the assertion is worth backporting to 22.11, too.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 4, 2023
@K900 K900 merged commit 0d13ad0 into NixOS:master Mar 4, 2023
@vcunat
Copy link
Member

vcunat commented Mar 4, 2023

Also #219457

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cannot-rebuild-due-to-conntrack-helper-error-after-updating-channels-and-attempt-to-upgrade/27523/2

@SuperSandro2000
Copy link
Member

How do I migrate away from this setting? Need to have access to the sysctl setting net.netfilter.nf_conntrack_max at boot to increase it. When not auto loading the conntrack helpers, the setting does not exist.

@vcunat
Copy link
Member

vcunat commented May 23, 2023

I don't know this stuff, but I still have /proc/sys/net/netfilter/nf_conntrack_max on default-ish 6.1 kernel.

@SuperSandro2000
Copy link
Member

That path was in the past not available on boot when the sysctl settings are applied and I needed to load the conntrack module early on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants