qt5.qtwebengine: point build at proper pkg-config for cross #220319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ofborg
bot
added
the
6.topic: cross-compilation
When cross-compiling, qmake insists on being able to find a
`pkgsHostForTarget`-style `pkg-config` with the name `pkg-config`
(no target prefix allowed).
To keep `qmake` happy, this commit creates a one-symlink derivation
containing a link `pkg-config` which points to
`${targetPrefix}pkg-config`.
This commit also sets the `PKG_CONFIG` environment variable.
| # qtwebengine expects to find an executable in $PATH which runs on | ||
| # the build platform yet knows about the host `.pc` files. Most | ||
| # configury allows setting $PKG_CONFIG to point to an | ||
| # arbitrarily-named script which serves this purpose; however QT |
There was a problem hiding this comment.
Why not patch that out instead?
| # arbitrarily-named script which serves this purpose; however QT | ||
| # insists that it is named `pkg-config` with no target prefix. So | ||
| # we re-wrap the host platform's pkg-config. | ||
| pkg-config-wrapped-without-prefix = stdenv.mkDerivation { |
There was a problem hiding this comment.
If you are only running commands in installPhase you probably want to use runCommand instead
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
12 tasks
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling, qmake insists on being able to find a
pkgsHostForTarget-stylepkg-configwith the namepkg-config(no target prefix allowed).To keep
qmakehappy, this commit creates a one-symlink derivation containing a linkpkg-configwhich points to${targetPrefix}pkg-config.This commit also sets the
PKG_CONFIG_EXECUTABLEenvironment variable.