Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated #220518

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

Artturin
Copy link
Member

https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Mar 11, 2023

@ofborg build v4l-utils

@Artturin
Copy link
Member Author

Artturin commented Mar 15, 2023

qtbase propagatedBuildInputs a lot of packages which now won't be in PATH and nor will their propagatedBuildInputs be

most build==host breakages caused by this will be packages using buildPythonPackage(because it has strictDeps)

there will most likely be more cross breakages

@SuperSandro2000
Copy link
Member

@ofborg eval

@ghost
Copy link

ghost commented Oct 24, 2023

@Artturin any chance you might undraftify this? We should merge it.

@Artturin
Copy link
Member Author

There's splicing issues due to the use of self so I'm fixing those

@Artturin
Copy link
Member Author

Artturin commented Nov 1, 2023

Split the qt5: commits to #264903 because they're not breaking

broken by "qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated"
qtbase propagates a lot of stuff

frescobaldi> msgcat -o - frescobaldi/cs.po userguide/cs.po | msgfmt -o ../frescobaldi_app/i18n/cs.mo -
frescobaldi> sh: line 1: msgcat: command not found
frescobaldi> sh: line 1: msgfmt: command not found
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants