Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: 0.12.0 -> 0.13.0 #220754

Merged
merged 1 commit into from
Mar 13, 2023
Merged

ko: 0.12.0 -> 0.13.0 #220754

merged 1 commit into from
Mar 13, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Mar 12, 2023

Diff: ko-build/ko@v0.12.0...v0.13.0

Changelog: https://github.com/ko-build/ko/releases/tag/v0.13.0

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@developer-guy
Copy link
Member

I think we should hold this update for a bit since there might be a new ko release to fix a bunch of issues about the release workflow I guess, @imjasonh WDYT?

ko-build/ko#979 (comment)

@vdemeester
Copy link
Member

I think we should hold this update for a bit since there might be a new ko release to fix a bunch of issues about the release workflow I guess, @imjasonh WDYT?

ko-build/ko#979 (comment)

oh indeed, thanks @developer-guy, I didn't see this 😅

@developer-guy
Copy link
Member

but it seems that @imjason already made this upgrade on Wolfi OS project, so, we may consider that it is safe to continue to do this upgrade 🤔

wolfi-dev/os#734 (comment)

@imjasonh
Copy link

but it seems that @imjason already made this upgrade on Wolfi OS project, so, we may consider that it is safe to continue to do this upgrade 🤔

wolfi-dev/os#734 (comment)

FWIW I think it's fine to package ko v0.13.0 in wolfi and nixpkgs even if we decide to cut v0.13.1 to fix the image signing issue. The ko source and binary are both good to go, it's only the image artifact that should be materially different, and neither wolfi nor nixpkgs care about that.

@fpletz fpletz merged commit d0c9a53 into NixOS:master Mar 13, 2023
@NickCao NickCao deleted the ko branch March 14, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants