Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-meta.nix: fix self-contradictory error messages #222852

Merged
merged 1 commit into from Mar 24, 2023
Merged

check-meta.nix: fix self-contradictory error messages #222852

merged 1 commit into from Mar 24, 2023

Commits on Mar 24, 2023

  1. check-meta.nix: fix self-contradictory error messages

    See #222792 (review)
    
    You can't just `lib.filter _ lib.systems.all` -- that throws away
    important information, leading to nixpkgs disagreeing with itself
    like this:
    
    ```
    $ NIXPKGS_ALLOW_BROKEN=1 nix-instantiate . -A pkgsStatic.systemd
    error: Package ‘systemd-252.5’ in ... is only supported on ... x86_64-linux but not on requested x86_64-linux, refusing to evaluate.
    ```
    
    After:
    
    ```
    $ NIXPKGS_ALLOW_BROKEN=1 nix-instantiate . -A pkgsStatic.systemd
    error: Package ‘systemd-252.5’ in ... is not available on the requested hostPlatform:
             hostPlatform.config = "x86_64-unknown-linux-musl"
             package.meta.platforms = [
               "aarch64-linux"
               "armv5tel-linux"
               "armv6l-linux"
               "armv7a-linux"
               "armv7l-linux"
               "i686-linux"
               "m68k-linux"
               "microblaze-linux"
               "microblazeel-linux"
               "mipsel-linux"
               "mips64el-linux"
               "powerpc64-linux"
               "powerpc64le-linux"
               "riscv32-linux"
               "riscv64-linux"
               "s390-linux"
               "s390x-linux"
               "x86_64-linux"
             ]
             package.meta.badPlatforms = [
               {
                 isStatic = true;
                 parsed = { };
               }
             ]
           , refusing to evaluate.
    ```
    Adam Joseph committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    13507da View commit details
    Browse the repository at this point in the history