-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_git.libcxx: LLVM15 changes and libcxxrt on FreeBSD #223255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaitoBezarius
force-pushed
the
llvmPackages_git.libcxx-tests
branch
3 times, most recently
from
March 26, 2023 15:21
2fd4094
to
7702f9f
Compare
48 tasks
Port of bc4dbee ("llvmPackages_15: updates for LLVM 15"). None of the patches required any touch-up; the only change of note is: - due to changes in the libc++/libc++abi build (https://reviews.llvm.org/D120719 and https://reviews.llvm.org/D131037) we have to add an extra build option to the libc++ header only build that sidesteps bits of the libc++ build config that assume libc++-abi is present in the build: https://github.com/llvm/llvm-project/blob/4f827318e3e8ccab4ff131e06234caa827e91e4e/libcxx/src/CMakeLists.txt#L255-L256 Rather than maintaining a precise set of build options that let us dodge referencing libc++-abi variables in the libc++ header only build, we set `LIBCXX_CXX_ABI` to `none`, as suggested by @lovesegfault. More discussion about this here: #194634 (comment) Co-authored-by: Bernardo Meurer <bernardo@meurer.org>
…e LLVM stdenv Port of 8db72e3 ("llvmPackages_15.libcxxabi: fix cycles that arise when `stdenv` is the LLVM stdenv").
Port of 4fabcf4 ("llvmPackages_15: apply #211230 to llvmPackages_15"). See the comments here for context: #194634 (comment) Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
This has not been added for `llvmPackages_15.libcxx`, therefore, we do not need it anymore.
RaitoBezarius
force-pushed
the
llvmPackages_git.libcxx-tests
branch
from
April 5, 2023 15:27
7702f9f
to
92bf933
Compare
@ofborg build llvmPackages_git.libcxx |
rrbutani
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The preInstall
on libcxx
indeed isn't needed anymore; IIRC switching to using the the clang built alongside libcxx
removed the need to patch out the "other" libcxxabi dylib.
@ofborg build llvmPackages_git.libcxx |
rrbutani
added
the
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
label
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
10.rebuild-darwin: 0
10.rebuild-linux: 0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport from LLVM15.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)