fractal: fix build due to git dependencies in Cargo.lock #224093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Due to 4329de1
fractal failed to build, this PR should fix the issue.
@L911P, @LostAttractor, @NickCao, can you test if this fixes the issue (I'm not sure how to get rid of cached dependencies, as it still compiled for me without this, I guess I would need to do a garbage collect or something)?
Btw. I have first used something like this to avoid putting to much bloat (
Cargo.lock
) into nixpkgs:but due to to
--no-allow-import-from-derivation
in nixpkgs-review it fails, as eval depends on a derivation that has to be build. Is there a better way to do this instead of including the Cargo.lock directly, without having to depend on a build (e.g. builtins.fetchers)?Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)