Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux/default.nix: use mipsel.nix instead of longson.nix for mips32 #224325

Merged
merged 1 commit into from Apr 2, 2023
Merged

linux/default.nix: use mipsel.nix instead of longson.nix for mips32 #224325

merged 1 commit into from Apr 2, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2023

Description of changes

Right now our bootstrapFiles-selecting algorithm uses the loongson2f.nix bootstrapFiles (which were not built by Hydra).

These bootstrapFiles don't work anymore. They were added in 2010 by 40405d0.

This commit causes mipsel-linux native builds to use the Hydra-built bootstrap files from this PR instead:

#183487

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 2, 2023
Right now our bootstrapFiles-selecting algorithm uses the
`loongson2f.nix` bootstrapFiles (which were not built by Hydra).

These bootstrapFiles don't work anymore.  They were added in 2010 by
40405d0.

This commit causes mipsel-linux native builds to use the Hydra-built
bootstrap files from this PR instead:

  #183487
@ghost ghost marked this pull request as ready for review April 2, 2023 06:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 2, 2023
@RaitoBezarius RaitoBezarius requested a review from trofi April 2, 2023 08:19
@trofi trofi merged commit f845fda into NixOS:master Apr 2, 2023
@ghost ghost deleted the pr/mipsel/not-longson branch April 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant