Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

earthly: 0.6.23 -> 0.7.2 #224335

Closed

Conversation

camerondurham
Copy link

Description of changes
  1. Excluded ./ast and ./utils/deltautil from build due to package not building with these
  2. Excluded binary earthly-shellrepeater which appears to have been remove when moving from earthly 0.6.x to 0.7

Changelog for Earthly 0.7.2 in earthly/earthly/CHANGELOG.md

I'm new to patching nix packages and am happy to revert on things I missed. Following as best I could from existing closed PRs bumping earthly in this repository: https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+earthly+is%3Aclosed

Thanks!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Local Testing Details

nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
cat report.json
{
    "blacklisted": [],
    "broken": [],
    "built": [],
    "extra-nixpkgs-config": null,
    "failed": [],
    "non-existant": [],
    "pr": null,
    "system": "aarch64-darwin",
    "tests": []
}

Build and run CLI locally on existing project using an Earthfile

nix-collect-garbage && nix-build -A earthly
ls ./result/bin
docker2earth     earthly          earthly-debugger

./result/bin/earthly --version
earthly version v0.7.2  darwin/arm64; macOS 13.3


NIX_BUILD_EARTHLY=~/nixpkgs/result/bin/earthly 

$NIX_BUILD_EARTHLY --ci +ci

@alyssais
Copy link
Member

alyssais commented Apr 2, 2023

Please follow the commit message guidelines in CONTRIBUTING.md.

@camerondurham camerondurham changed the title Bump earthly version 0.6.23 -> 0.7.2 earthly: 0.6.23 -> 0.7.2 Apr 2, 2023
@konradmalik konradmalik mentioned this pull request Jun 2, 2023
12 tasks
@SuperSandro2000
Copy link
Member

Closing in favor of #234965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants