Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.11] python3Packages.tensorflow: add patches for many CVEs #224988

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 6, 2023

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2023-27579
https://nvd.nist.gov/vuln/detail/CVE-2023-25801
https://nvd.nist.gov/vuln/detail/CVE-2023-25676
https://nvd.nist.gov/vuln/detail/CVE-2023-25675
https://nvd.nist.gov/vuln/detail/CVE-2023-25674
https://nvd.nist.gov/vuln/detail/CVE-2023-25673
https://nvd.nist.gov/vuln/detail/CVE-2023-25671
https://nvd.nist.gov/vuln/detail/CVE-2023-25670
https://nvd.nist.gov/vuln/detail/CVE-2023-25669
Not https://nvd.nist.gov/vuln/detail/CVE-2023-25668 (see tensorflow/tensorflow@1c2e7f4)
https://nvd.nist.gov/vuln/detail/CVE-2023-25667
https://nvd.nist.gov/vuln/detail/CVE-2023-25665
https://nvd.nist.gov/vuln/detail/CVE-2023-25666
https://nvd.nist.gov/vuln/detail/CVE-2023-25664
https://nvd.nist.gov/vuln/detail/CVE-2023-25663
https://nvd.nist.gov/vuln/detail/CVE-2023-25662
https://nvd.nist.gov/vuln/detail/CVE-2023-25660
https://nvd.nist.gov/vuln/detail/CVE-2023-25659
https://nvd.nist.gov/vuln/detail/CVE-2023-25658

Still have to mark the -bin variant insecure as we can't patch that.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@risicle risicle force-pushed the ris-tensorflow-CVEs-202303-r22.11 branch from fa0d047 to 0431d34 Compare April 6, 2023 13:17
@risicle risicle marked this pull request as ready for review April 7, 2023 15:47
@Waelwindows
Copy link
Contributor

Builds successfully on aarch64-darwin. Did not test the built derivation tho.

@gmacon
Copy link
Contributor

gmacon commented Apr 8, 2023

Builds on x86_64-darwin, and a built-in command produces help output:

$ nix build github:NixOS/nixpkgs/pull/224988/head#python3Packages.tensorflow
$ ./result/bin/saved_model_cli --help
2023-04-08 11:30:17.299860: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  SSE4.2 AVX AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
usage: saved_model_cli [-h] [-v] {show,run,scan,convert,aot_compile_cpu,freeze_model} ...

saved_model_cli: Command-line interface for SavedModel

options:
  -h, --help            show this help message and exit
  -v, --version         show program's version number and exit

commands:
  valid commands

  {show,run,scan,convert,aot_compile_cpu,freeze_model}
                        additional help

@vcunat vcunat merged commit 4bbbb53 into NixOS:release-22.11 Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants