Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sane_backends: disable parallel install #225339

Merged

Conversation

symphorien
Copy link
Member

for some reason that prevents libsane from finding plugins

Fixes #224569

I find this solution hard to believe, please double check.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 8, 2023
@Artturin
Copy link
Member

Artturin commented Apr 9, 2023

Do a diffoscope before and after this change maybe that'll reveal the issue

@symphorien
Copy link
Member Author

diffoscope --html report.html --diff-mask 'cb76rxa72qn4pw6c54ha014hh08p3mw9|k05n99qgzjydsy7855asrndss345b2ix' fixed_sane broken_sane

https://blitiri.xlumurb.eu/~/report.html

I see no meaningful change, and yet I double checked with nixos-rebuild build-vm that I get a listing with this commit and not without. This makes no sense.

@symphorien
Copy link
Member Author

Ah there is actually a difference hidden deep in the diff: the broken sane has one more symlik:
image

$  ls {broken,fixed}_sane/lib/{sane/,}libsane.so.1 -lah
ls: impossible d'accéder à 'fixed_sane/lib/sane/libsane.so.1': No such file or directory
lrwxrwxrwx 31 root root 16  1 janv.  1970 broken_sane/lib/libsane.so.1 -> libsane.so.1.2.1
lrwxrwxrwx 35 root root 26  1 janv.  1970 broken_sane/lib/sane/libsane.so.1 -> libsane-xerox_mfp.so.1.2.1
lrwxrwxrwx 31 root root 16  1 janv.  1970 fixed_sane/lib/libsane.so.1 -> libsane.so.1.2.1

and a symlink from libsane.so to libsane-xerox_mfp.so does not make sense. maybe it breaks everything.

@Artturin
Copy link
Member

Artturin commented Apr 9, 2023

Let's add that to the comment and merge

Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comment on diffoscope stuff is added, let's merge.

@VShell
Copy link
Contributor

VShell commented Apr 10, 2023

Having been trying to work this out today separately, I found the following comment suggesting the generation of this file is an issue with how they use libtool:

https://gitlab.com/sane-project/backends/-/blob/90cc6b1fb73212cec32196d4c0a66568b2130eec/backend/Makefile.am#L114-116

It'd seem the file is getting regenerated some time after that rm with parallel install.

@symphorien symphorien force-pushed the sane_plugins_parallel_install branch from a19a994 to f9c5b55 Compare April 10, 2023 10:50
@symphorien
Copy link
Member Author

Fixed the comment.

parallel install creates a bad symlink at $out/lib/sane/libsane.so.1
which prevents finding plugins.

Fixes NixOS#224569
@RaitoBezarius RaitoBezarius merged commit ca3bd88 into NixOS:master Apr 12, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brother-scanner-no-longer-recognized-by-scanimage/27183/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sane-backends: fails to find any scanners
5 participants