rav1e: fix cross #225360
Merged
rav1e: fix cross #225360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build pkgsCross.aarch64-multiplatform.rav1e |
|
@ofborg eval |
ofborg
bot
added
the
6.topic: cross-compilation
|
Fp to get green status |
Merged
`cargo cbuild` needs to have the `C{C,XX}_FOR_{${platform}}`
variables set just like `cargo` since it is basically a wrapper
around cargo. Without these variables, it will try to use the
`hostPlatform` C compiler to compile `build.rs` scripts, and will
pass flags to that compiler which only make sense on the
`buildPlatform`. So it's just doomed without the environment
variables.
Right now it looks like `rav1e` is the only package we have that is
using `cargo-c`, but if that changes in the future we should factor
this out as its own hook, like `maturinBuildHook` and the others.
ghost
deleted the
|
Note to self, this PR contains the trick for fixing |
ghost
mentioned this pull request
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo cbuildneeds to have theC{C,XX}_FOR_{${platform}}variables set just likecargosince it is basically a wrapper around cargo. Without these variables, it will try to use thehostPlatformC compiler to compilebuild.rsscripts, and will pass flags to that compiler which only make sense on thebuildPlatform. So it's just doomed without the environment variables.Right now it looks like
rav1eis the only package we have that is usingcargo-c, but if that changes in the future we should factor this out as its own hook, likematurinBuildHookand the others.Closes #225356
Sorry about spamming everybody by calling
git hub pull newwithout--base staging.Things done
x86_64-linux)